Roundup Robot added the comment:
New changeset 8afd995802a6 by Robert Collins in branch '2.7':
Issue #23254: Document how to close the TCPServer listening socket.
https://hg.python.org/cpython/rev/8afd995802a6
New changeset 1123de53195e by Robert Collins in branch '3.4':
Issue #23254: Document
Robert Collins added the comment:
Applied to 2.7/3.4/3.5/3.6. Thanks!
--
nosy: +rbcollins
resolution: - fixed
stage: commit review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23254
R. David Murray added the comment:
In general documentation changes go in all maintained versions (ie: right now
that would be 2.7, 3.4, and default/3.5). The only exception, really, would be
if the change didn't apply to one or more of the versions because of code
differences. (Note: I
Martin Panter added the comment:
Posting server_close.v2.patch, which tests fileno(), and uses a single space
between the new sentences. Also added a bit to the how-to at the top (using
doubly-spaced sentences to match the rest of the paragraph).
--
Added file:
Demian Brecht added the comment:
LGTM. I'm not sure whether or not it's eligible for 3.4 though as it's a
documentation and not a functional fix.
--
stage: patch review - commit review
___
Python tracker rep...@bugs.python.org
Demian Brecht added the comment:
Left a couple small nitpicks in Rietveld. Otherwise LGTM.
--
nosy: +demian.brecht
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23254
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
nosy: +haypo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23254
___
___
Python-bugs-list
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23254
___
Martin Panter added the comment:
Here is a simple patch to add server_close() to the documentation, and a simple
test to ensure it closes the socket.
--
keywords: +patch
versions: +Python 3.4, Python 3.5
Added file: http://bugs.python.org/file37940/server_close.patch
New submission from Martin Panter:
Running the example from the Asynchronous Mixins section of the “socketserver”
documentation generates a ResourceWarning:
$ ./python -btWall ThreadedTCPServer.py
Server loop running in thread: Thread-1
Received: Thread-2: Hello World 1
Received: Thread-3:
10 matches
Mail list logo