[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: Minor update based on Demian’s review -- Added file: http://bugs.python.org/file39769/http-buffer.v4.patch ___ Python tracker ___ ___

[issue23377] HTTPResponse may drop buffer holding next response

Demian Brecht added the comment: Actually had a few free minutes so stuck a couple minor comments in Rietveld. Will have another go as soon as possible. -- ___ Python tracker __

[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: Just realized that the makefile() call in _tunnel() still lets this bug occur when a HTTPSConnection is being used with a proxy using the CONNECT method. So while my patch shouldn’t make things any worse than they already are, it needs more work to fix this ins

[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: Thanks for the reviewing. Here is http-buffer.v3.patch: * Merged with current code * Better HTTPResponse(sock) compatibility suggested by Demian * New HTTPConnection.request(close=True) feature also suggested by Demian. This sends “Connection: close” in the requ

[issue23377] HTTPResponse may drop buffer holding next response

Demian Brecht added the comment: Added comments to Rietveld. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23377] HTTPResponse may drop buffer holding next response

Demian Brecht added the comment: If nobody else gets to it first, I'll try to get to review this later today or tomorrow. Apologies for the delay on the review Martin, a new baby (coming next month), moving /and/ taking on a new job all at the same time seems to limit free time a little ;) --

[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: Yes I would like someone to review my code changes for this; I don’t think anyone has done so yet. But I don’t consider this a very important bug, so there is no hurry. -- keywords: +needs review ___ Python tracker

[issue23377] HTTPResponse may drop buffer holding next response

Antoine Pitrou added the comment: Is this pending a review? -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23377] HTTPResponse may drop buffer holding next response

Demian Brecht added the comment: > I think it's ok to slightly break a non-public API since it's required to fix > an obvious bug. To play devil's advocate here, /is/ this really non-public API? According to documented Python naming conventions, HTTPResponse is part of the public API. From co

[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: HTTP pipelining is not supported in general. According to the module doc string, you can actually pipeline a second request if you have read the first response’s headers but not its body: >>> conn = HTTPSConnection("bugs.python.org") >>> conn.request("GET", "/"

[issue23377] HTTPResponse may drop buffer holding next response

Antoine Pitrou added the comment: I think it's ok to slightly break a non-public API since it's required to fix an obvious bug. By the way, I guess we don't support HTTP pipelining, right? -- stage: -> patch review ___ Python tracker

[issue23377] HTTPResponse may drop buffer holding next response

Changes by Antoine Pitrou : -- nosy: +demian.brecht, pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue23377] HTTPResponse may drop buffer holding next response

Martin Panter added the comment: http-buffer.v2.patch: * Merged with recent changes * Made the changes to the test suite slightly less intrusive. Unfortunately there are still a lot of changes left where mock sockets were being sent into the HTTPResponse constructor. -- Added file: ht

[issue23377] HTTPResponse may drop buffer holding next response

New submission from Martin Panter: This is the same issue raised at . Currently, every time a new response is to be received, HTTPConnection passes its raw socket object to HTTPResponse, which calls sock.makefile("rb") and creates a BufferedReader. T