[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset a84ae2ccd220 by Serhiy Storchaka in branch 'default': Issue #23450: Fixed possible integer overflows. https://hg.python.org/cpython/rev/a84ae2ccd220 New changeset 1eee26b74e4b by Serhiy Storchaka in branch 'default': Issue #23450: Silenced compiler

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-16 Thread Serhiy Storchaka
Changes by Serhiy Storchaka storch...@gmail.com: -- assignee: - serhiy.storchaka resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-16 Thread Roundup Robot
Roundup Robot added the comment: New changeset f47d683b6c9e by Serhiy Storchaka in branch 'default': Fixed sizeof tests for ElementTree (issue #23450). https://hg.python.org/cpython/rev/f47d683b6c9e -- ___ Python tracker rep...@bugs.python.org

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-13 Thread Steve Dower
Steve Dower added the comment: int_overflows.patch looks good to me. I really appreciate that these patches have been done properly too - I've seen far too much code where people just throw in casts to silence the warnings. This is why I like working on Python :) --

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread STINNER Victor
STINNER Victor added the comment: The 64-bit support of Windows is still incomplete :-/ We tried to fix most of them, but there are still remaining issues. The main issue is #9566. I opened for example the issue #18295: Possible integer overflow in PyCode_New(). --

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread STINNER Victor
STINNER Victor added the comment: signal_cast_socket_t.patch: Fix warning in signal.set_wakeup_fd(). I introduced recently the warning when I added support for sockets in this function on Windows. -- Added file: http://bugs.python.org/file38109/signal_cast_socket_t.patch

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Please ignore changes to Objects/codeobject.c, Objects/funcobject.c and Python/ceval.c. The patch in issue18295 is more advanced. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Here is a patch which fixes many warnings reported by MS compiler on 64-bit platform [1]. Some of these warnings indicated real bugs. [1] http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/411/steps/compile/logs/warnings%20(396)

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread Steve Dower
Steve Dower added the comment: Wow, I didn't expect that so quickly :) I'll check these out as soon as I can, but they look okay from a quick glance on my phone. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: signal_cast_socket_t.patch LGTM. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450 ___ ___

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-12 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9e10c4255277 by Victor Stinner in branch 'default': Issue #23450: Fix signal.set_wakeup_fd() on Windows https://hg.python.org/cpython/rev/9e10c4255277 -- nosy: +python-dev ___ Python tracker

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-11 Thread Mark Lawrence
New submission from Mark Lawrence: The attached file lists many of the warnings, but note there may be more as tkinter didn't build and is subject to #23449. -- components: Build, Windows files: PossibleLossOfData.txt messages: 235777 nosy: BreamoreBoy, steve.dower, tim.golden,

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-11 Thread Mark Lawrence
Mark Lawrence added the comment: Using Microsoft Visual Studio Express 2013 for Windows Desktop. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450 ___

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-11 Thread Steve Dower
Steve Dower added the comment: These are warnings about implicit downcasting in a 64-bit build. They're not fatal to the build or execution (as far as we know), and as nice as it would be to fix them all, good fixes may introduce behaviour changes (for example, new overflow errors). As an

[issue23450] Possible loss of data warnings building 3.5 Visual Studio Windows 8.1 64 bit

2015-02-11 Thread Mark Lawrence
Mark Lawrence added the comment: Changes to nosy list as advised by Terry Reedy on c.l.py -- nosy: +haypo, serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23450 ___