Brett Cannon added the comment:
Thanks for the patch, Paul! I touched up the formatting to be more PEP 8
compliant and fixed the tests as they initially failed for me (TESTFN didn't
exist prior to you trying to make a directory, so it just failed; switched to
tempfile.TemporaryDirectory
Roundup Robot added the comment:
New changeset d1e9f337fea1 by Brett Cannon in branch 'default':
Issue #23491: Implement PEP 441: Improving Python Zip Application Support
https://hg.python.org/cpython/rev/d1e9f337fea1
--
nosy: +python-dev
___
Python
Paul Moore added the comment:
Thanks Brett! Apologies about the TESTFN issue - I changed it (from
TemporaryDirectory, in fact) based on one of the review comments - it looks
like I didn't test the change properly. My mistake, thanks for catching it.
--
Paul Moore added the comment:
Steve Dower - could you please review the updated patch here. The WiX changes
specifically are intended to register the .pyz extension with the launcher, but
I can see no code that does this for a per-user install. I've copied the same
code for the .py extension
Paul Moore added the comment:
There's a problem with the latest patch, it's lost the MSI updates somehow.
I'll add them back in this evening, please don't commit before a v6 patch is
available,
--
___
Python tracker rep...@bugs.python.org
Steve Dower added the comment:
The whole installer is run with a different global flag depending on the type
of install. So it's automatic, though sometimes you can't do both per-user and
all-user changes at the same time (not that you should anyway).
--
Paul Moore added the comment:
OK, so if the installer changes look good to you, then this PR is once again
ready to go. Sorry to anyone watching for the glitch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
Berker Peksag added the comment:
I left a couple of minor comments on Rietveld.
--
nosy: +berker.peksag
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Paul Moore added the comment:
New patch incorporating Berker's comments
--
Added file: http://bugs.python.org/file38389/pep-441.v5.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
Paul Moore added the comment:
There have been no further comments for a while now. Could this be committed by
someone?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Serhiy Storchaka added the comment:
There is not well known old way how to make executable Python files on Windows.
Add line @python -x %0 %* at the start of your Python script and rename the
script to *.bat. The -x option makes Python to skip first line that is not
Python, and @ forbids
Paul Moore added the comment:
I'm -1 on this. The whole point of having a .pyz extension is so that you don't
need to use an extension that's for files containing text to hold binary data.
If you want to do this, use zipapp and specify no interpreter line, then add
the @python line yourself.
Paul Moore added the comment:
Updated patch including (I hope!) all review comments so far.
--
Added file: http://bugs.python.org/file38258/pep-441.v4.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
Changes by Paul Moore p.f.mo...@gmail.com:
Removed file: http://bugs.python.org/file38249/pep-441.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Paul Moore added the comment:
OK, thanks. I don't propose to go there with the initial implementation. If
it's a problem in practice, someone can raise a bug and we'll fix it then.
(I've never seen actual Python code in the wild that does all of that...)
--
Paul Moore added the comment:
OK, here is an updated patch based on the python-dev discussions
--
Added file: http://bugs.python.org/file38249/pep-441.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
Paul Moore added the comment:
Sorry - typo. Try again...
--
Added file: http://bugs.python.org/file38250/pep-441.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Jim Jewett added the comment:
I think that instead of application/zip, you want application/zipped-python (or
whatever the precise term was). This was one reason to register the MIME type.
That said, application/zip is probably not harmful; the worst it should do it
hand the archive to a
Paul Moore added the comment:
If I understand Steve's comments, the mime type is used by Windows, so
application/zip lets Windows know that this filetype is fundamentally a zip
file (and so it'll offer to open it with your zip program if you right click,
stuff like that).
pxzw - the w on the
Steve Dower added the comment:
The .px* extensions are for testing builds without messing up your actual file
associations. I ported them forward from the old installer, but most people
will never see them.
--
___
Python tracker
Steve Dower added the comment:
There's also a PerceivedType property which we could set to make sure that
archivers correctly light up. I think that'll get you the built-in Extract
command. Most tools appear on every file and will try and read it to see what
commands make sense, which will
Daniel Holth added the comment:
On Thu, Feb 26, 2015, at 09:41 AM, Paul Moore wrote:
Paul Moore added the comment:
Following on from that, the code to make an archive executable is
currently
os.chmod(new_archive, os.stat(new_archive).st_mode | stat.S_IEXEC)
Should I use ... |
Paul Moore added the comment:
I don't follow (and I don't really want to do things this low level without a
compelling reason...)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Paul Moore added the comment:
Following on from that, the code to make an archive executable is currently
os.chmod(new_archive, os.stat(new_archive).st_mode | stat.S_IEXEC)
Should I use ... | stat.S_IXUSR | stat.S_IXGRP | stat.S_IXOTH? If so, do I
need to protect that with an if not Windows
Daniel Holth added the comment:
Create and open executable file respecting the Unix user's umask:
os.fdopen(os.open(filename, os.O_CREAT|os.O_RDWR), rw)
On Tue, Feb 24, 2015, at 02:34 PM, Paul Moore wrote:
Paul Moore added the comment:
Thanks, I'll fix for the next iteration of the
Serhiy Storchaka added the comment:
Did you noticed my comments to previous patch Paul?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Changes by Ethan Furman et...@stoneleaf.us:
--
nosy: +ethan.furman
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Emails from Rietveld often can be found in the spam folder.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Paul Moore added the comment:
Serhiy - I just got a notification from the review tool - I'd not used it
before and didn't know to check it. But I've read them now and corrected a
number of places based on your comments and added a few replies to the review.
Thanks for the review.
--
Serhiy Storchaka added the comment:
As for zipimport, it doesn't support namespace packages when no 'directory'
entry exists (issue14905). The zipfile module CLI now adds entries for
directories (issue22219).
--
___
Python tracker
Serhiy Storchaka added the comment:
Paul, don't click on Reply below the comment on the main page, it never works.
Instead click the link above the comment, then click on the comment to unfold
it, click on the Reply below the comment, enter your reply, press Send, and
after replying all
Paul Moore added the comment:
Serihy, thanks for the explanation. I was aware that my replies weren't getting
archived, good to know how to avoid that in future.
I've worked out what you mean over the directory entries now. It was easy
enough to fix - I just removed the is_file check before
Paul Moore added the comment:
Thanks, I'll fix for the next iteration of the patch.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
___
Daniel Holth added the comment:
Spelling
raise PackError(Cannot spacify entry point if the source has __main__.py)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
New submission from Paul Moore:
This is the patch for PEP 441 (Zip Application Support).
Steve, could you check the installer changes, please? I haven't managed to get
a setup where I can test the installer, and I'm not aware of any WiX coding
tools, so I just edited the XML files by hand
Steve Dower added the comment:
I haven't looked closely at the rest, btw. Will try and find time today or
tomorrow.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23491
___
___
Steve Dower added the comment:
The installer changes look fine, though there shouldn't be PATH related strings
in exe/, so there's probably a separate issue there. Wix doesn't really have
any editors that aren't just XML editors.
We probably want to update the ContentType value from
Paul Moore added the comment:
Thanks for checking, Steve. I don't get an installer because of the checksum
error quoted, although I did get the component msi files.
As far as content type is concerned, I wasn't sure what effect it had so I just
copied what was there. I guess application/zip
Steve Dower added the comment:
Either application/zip or application/x-zip-compressed, I'm not sure
exactly what the difference is, but the default .zip association has the latter.
The CRC error may be your machine or it may be because we're currently running
on unstable WiX releases (hey,
Paul Moore added the comment:
Thanks. Updated patch with the new mime-type.
Looks like there's disk errors on that file with the CRC check. Lovely :-)
--
Added file: http://bugs.python.org/file38192/pep441.patch
___
Python tracker
41 matches
Mail list logo
