Brett Cannon [EMAIL PROTECTED] added the comment:
On Sat, Aug 23, 2008 at 6:00 PM, Benjamin Peterson
[EMAIL PROTECTED] wrote:
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Those changes are great; thanks for the review! Are you happy enough
with it to let me apply?
Yep.
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Ok. Applied in r66013.
--
resolution: - fixed
status: open - closed
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
Brett Cannon [EMAIL PROTECTED] added the comment:
I reviewed the patch and made some changes (which I uploaded). Mostly
changed the punctuation of the warning, made sure that PyErr_WarnPy3k()
was used for all cases, and simplified the code for the test.
Assigning to Benjamin for him to decide
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Those changes are great; thanks for the review! Are you happy enough
with it to let me apply?
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
Changes by Brett Cannon [EMAIL PROTECTED]:
--
priority: critical - release blocker
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Changes by Brett Cannon [EMAIL PROTECTED]:
--
keywords: +needs review
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list
Changes by Georg Brandl [EMAIL PROTECTED]:
--
assignee: georg.brandl -
___
Python tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
___
___
Python-bugs-list
Benjamin Peterson [EMAIL PROTECTED] added the comment:
Here's a patch for that. It gives warnings on use of __getslice__,
__delslice__, and __setslice__ and includes tests.
But
it only works on new style classes. I don't think this is a big problem
because users will see the warnings when they
New submission from Brett Cannon [EMAIL PROTECTED]:
Using any of the slicing methods (e.g., __getslice__) should raise a
Py3K warning.
--
components: Interpreter Core
keywords: 26backport
messages: 63721
nosy: brett.cannon
priority: immediate
severity: normal
status: open
title: Using
Changes by Brett Cannon [EMAIL PROTECTED]:
--
priority: immediate - urgent
__
Tracker [EMAIL PROTECTED]
http://bugs.python.org/issue2351
__
___
Python-bugs-list mailing list
10 matches
Mail list logo