Roundup Robot added the comment:
New changeset fc0e79387a3a by Berker Peksag in branch 'default':
Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a.
https://hg.python.org/cpython/rev/fc0e79387a3a
--
nosy: +python-dev
___
Python
Berker Peksag added the comment:
Thanks!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23703
___
Martin Panter added the comment:
Any chance this regression can be fixed before the next release?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23703
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +berker.peksag
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23703
___
___
New submission from Martin Panter:
This is a regression caused by revision 901e4e52b20a. Before (e.g. Python 3.4):
urljoin('a', 'b')
'b'
After:
urljoin('a', 'b')
'b/b'
This was identified in https://bugs.python.org/issue18828#msg238363 but is
actually caused by the revision committed for
Demian Brecht added the comment:
Yep, that's a lot cleaner and tests pass. I've updated the patch with that
line. Thanks.
--
Added file: http://bugs.python.org/file38573/issue23703_1.patch
___
Python tracker rep...@bugs.python.org
Changes by Berker Peksag berker.pek...@gmail.com:
--
nosy: +orsenthil
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue23703
___
___
Python-bugs-list
Demian Brecht added the comment:
Nice work tracking down the commit, thanks for that. I've attached a fix.
--
keywords: +patch
stage: - patch review
Added file: http://bugs.python.org/file38563/issue23703.patch
___
Python tracker
Martin Panter added the comment:
Patch looks good enough.
BTW I was thinking of something like this, which is a bit simpler, but I never
tested it:
segments[1:-1] = filter(None, segments[1:-1])
--
___
Python tracker rep...@bugs.python.org
