[issue23703] urljoin() with no directory segments duplicates filename

[Berker Peksag]

Berker Peksag added the comment:

Thanks!

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Roundup Robot]

Roundup Robot added the comment:

New changeset fc0e79387a3a by Berker Peksag in branch 'default':
Issue #23703: Fix a regression in urljoin() introduced in 901e4e52b20a.
https://hg.python.org/cpython/rev/fc0e79387a3a

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Martin Panter]

Martin Panter added the comment:

Any chance this regression can be fixed before the next release?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Demian Brecht]

Demian Brecht added the comment:

Yep, that's a lot cleaner and tests pass. I've updated the patch with that 
line. Thanks.

--
Added file: http://bugs.python.org/file38573/issue23703_1.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Martin Panter]

Martin Panter added the comment:

Patch looks good enough.

BTW I was thinking of something like this, which is a bit simpler, but I never 
tested it:

segments[1:-1] = filter(None, segments[1:-1])

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Demian Brecht]

Demian Brecht added the comment:

Nice work tracking down the commit, thanks for that. I've attached a fix.

--
keywords: +patch
stage:  -> patch review
Added file: http://bugs.python.org/file38563/issue23703.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +orsenthil

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue23703] urljoin() with no directory segments duplicates filename

[Martin Panter]

New submission from Martin Panter:

This is a regression caused by revision 901e4e52b20a. Before (e.g. Python 3.4):

>>> urljoin('a', 'b')
'b'

After:

>>> urljoin('a', 'b')
'b/b'

This was identified in  but is 
actually caused by the revision committed for Issue 22278.

--
components: Library (Lib)
messages: 238493
nosy: demian.brecht, vadmium
priority: normal
severity: normal
status: open
title: urljoin() with no directory segments duplicates filename
type: behavior
versions: Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com