[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by Zackery Spytz : -- versions: +Python 2.7, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

miss-islington added the comment: New changeset 8a0c254fdd68cfafede168356fc5c5c3e372bc3f by Miss Islington (bot) in branch '3.6': bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038) https://github.com/python/cpython/commit/8a0c254fdd68cfafede168356fc5c5c3e372bc3f --

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

miss-islington added the comment: New changeset f51a46631f8dcca596c08a934a766da9afe93c06 by Miss Islington (bot) in branch '2.7': bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038) https://github.com/python/cpython/commit/f51a46631f8dcca596c08a934a766da9afe93c06 --

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by miss-islington : -- pull_requests: +8568 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by miss-islington : -- pull_requests: +8569 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.6 ___ Python tracker ___

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

miss-islington added the comment: New changeset 73994077250bd70385cb8e7a92f24874129369d1 by Miss Islington (bot) in branch '3.7': bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038) https://github.com/python/cpython/commit/73994077250bd70385cb8e7a92f24874129369d1 --

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by miss-islington : -- pull_requests: +8564 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Berker Peksag added the comment: New changeset 4e519377b1b84c9414a360961276993d24198825 by Berker Peksag (Zackery Spytz) in branch 'master': bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038) https://github.com/python/cpython/commit/4e519377b1b84c9414a360961276993d24198825

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Change by Zackery Spytz : -- pull_requests: +8499 stage: -> patch review ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Zackery Spytz added the comment: The suggested patch is not acceptable: MemoryError should be raised in the unlikely event of a malloc() failure, there's a missing call to MsiCloseHandle(), the use of tabs violates PEP 7, and there's a blatant syntax error. -- nosy: +ZackerySpytz

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

Bill Parker added the comment: In directory 'PC', file '_msi.c', I found another call to malloc() which was not checked for a return value of NULL which would indicate failure. The new patch file is below: --- _msi.c.orig 2015-04-02 15:01:02.882326352 -0700 +++ _msi.c 2015-04-04

[issue23855] Missing Sanity Check for malloc() in PC/_msi.c

New submission from Bill Parker: Hello All, In reviewing code in Python-3.4.3/PC/_msi.c, I found a call to malloc() at line 326 in function 'static PyObject* msierror(int status)' in which the call is made and assigned to variable 'res', but no check for NULL, indicating failure is made