[issue23936] Wrong references to deprecated find_module instead of find_spec

Thomas Kluyver added the comment: Updated patch attached, responding to Martin's suggestions. I'm not quite sure what to do about the 'finder' glossary entry. 'Finder' now seems to be a more abstract classification covering two distinct kinds of thing: *meta path finders* and *path entry

[issue23936] Wrong references to deprecated find_module instead of find_spec

Thomas Kluyver added the comment: That's basically what I was aiming for. Should the description be briefer and more generic? -- ___ Python tracker ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

Brett Cannon added the comment: The generic "finder" glossary entry should be rather generic and then point to "meta path finder" and "path entry finder" for dis-ambiguity (and both of those terms are already in the glossary). -- ___ Python tracker

[issue23936] Wrong references to deprecated find_module instead of find_spec

Thomas Kluyver added the comment: Thanks Brett :-) -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue23936] Wrong references to deprecated find_module instead of find_spec

Roundup Robot added the comment: New changeset 88cee7d16ccb by Brett Cannon in branch '3.5': Issue #23936: Clarify what finders are. https://hg.python.org/cpython/rev/88cee7d16ccb New changeset 1b1900d2a537 by Brett Cannon in branch 'default': Merge for issue #23936

[issue23936] Wrong references to deprecated find_module instead of find_spec

Brett Cannon added the comment: I vote for more generic; left a review to that effect. -- ___ Python tracker ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

Thomas Kluyver added the comment: Third revision of patch responding to Brett's suggestions. -- Added file: http://bugs.python.org/file41240/finders_and_specs3.patch ___ Python tracker

[issue23936] Wrong references to deprecated find_module instead of find_spec

Brett Cannon added the comment: LGTM; I will commit it when I have a chance. -- stage: patch review -> commit review ___ Python tracker ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

Changes by Brett Cannon : -- assignee: docs@python -> brett.cannon ___ Python tracker ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

Thomas Kluyver added the comment: I also ran into confusion with this while trying to write an import hook. Attached is my shot at a docs patch. I've done a slightly larger rewording, trying to make it easier to understand, and added more links between parts of the docs. I left mentions of

[issue23936] Wrong references to deprecated find_module instead of find_spec

Martin Panter added the comment: Thanks for adding that link to ModuleSpec, it is definitely needed to make sense of a lot of stuff. I left some review comments and questions. If the behaviour of sys.meta_path has changed, I think it needs a “New/changed in version X” notice. If it makes the

[issue23936] Wrong references to deprecated find_module instead of find_spec

Brett Cannon added the comment: You're right, it should be find_spec. -- nosy: +ncoghlan ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23936 ___

[issue23936] Wrong references to deprecated find_module instead of find_spec

Raúl Cumplido added the comment: Added changes on both places where there was still references to find_module without specifying that has been deprecated. -- keywords: +patch Added file: http://bugs.python.org/file39021/issue23936.patch ___ Python

[issue23936] Wrong references to deprecated find_module instead of find_spec

New submission from Raúl Cumplido: While taking a look on the import mechanisms I've seen in the documentation that find_module has been deprecated for find_spec, but on different parts of the documentation there are still references to find_module, as in the definition of sys.meta_path