[issue24004] avoid explicit generator type check in asyncio
Roundup Robot added the comment: New changeset 8296f0119f20 by Yury Selivanov in branch '3.5': Issue 24004: Fix DeprecationWarning in a unittest https://hg.python.org/cpython/rev/8296f0119f20 New changeset 60f5091cbfbf by Yury Selivanov in branch 'default': Issue 24004: Fix DeprecationWarning in a unittest https://hg.python.org/cpython/rev/60f5091cbfbf -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Yury Selivanov added the comment: Thanks, Martin! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Martin Panter added the comment: Yury, your last change causes DeprecationWarning: [ 38/398] test_asyncio /media/disk/home/proj/python/cpython/Lib/test/test_asyncio/test_pep492.py:119: DeprecationWarning: Please use assertEqual instead. self.assertEquals(coro.send(None), 'spam') -- nosy: +vadmium ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Changes by Yury Selivanov yseliva...@gmail.com: -- resolution: fixed - status: closed - pending ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Yury Selivanov added the comment: Why is the AwaitableABC type check needed, in addition to looking up the relevant method? IIUC, the type check will just do a lookup of the same method if the type hasn't been registered as Awaitable explicitly. Because __await__ should be defined on the class, not on the method (as for all other magic methods in Python). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: Cython functions that return a generator aren't special in any way, so it's actually correct that isgeneratorfunction() always returns False. I mean, I could set the CO_COROUTINE flag on the code object that we fake, but that wouldn't help much as Cython's functions are not Python functions, so isfunction() will also return False for them and no-one would look at the flag in the first place. And finally, a Cython generator is not a Python generator (with byte code position etc.), so isgenerator() also correctly returns False. At least iscoroutine() and iswaitable() will return True for Cython Coroutines now. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: Hmm, I just noticed that this only started failing when I disabled the asyncio module patching for 3.5beta1+, assuming that it now all works. A side effect of that was that also the inspect module is no longer patched into returning True from isgenerator() for Cython generators. While there might be code that fails when it tries to inspect Cython generators as Python generators (as the first don't have byte code), I think it's still the easiest fix to simply keep the inspect patching. That would then trigger the right code path here without changes in asyncio. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: ... except that the returned object may not actually be a Cython generator but a GeneratorWrapper, now that the patch from issue 24316 is in place. :) Then I guess we're back to the point where duck-typing and calling __await__() is a good idea. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Yury Selivanov added the comment: Stefan, Then I guess we're back to the point where duck-typing and calling __await__() is a good idea. Please test the attached patch. I agree this is a good idea. -- keywords: +patch Added file: http://bugs.python.org/file39569/coroutine.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: Works for me. Why is the AwaitableABC type check needed, in addition to looking up the relevant method? IIUC, the type check will just do a lookup of the same method if the type hasn't been registered as Awaitable explicitly. -- status: pending - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Roundup Robot added the comment: New changeset b7b73029c825 by Yury Selivanov in branch '3.4': Issue 24004: Support Awaitables (pep 492) in @asyncio.coroutine decorator https://hg.python.org/cpython/rev/b7b73029c825 New changeset d1959cafc68c by Yury Selivanov in branch '3.5': Issue 24004: Support Awaitables (pep 492) in @asyncio.coroutine decorator https://hg.python.org/cpython/rev/d1959cafc68c New changeset 6c53591d589b by Yury Selivanov in branch 'default': Issue 24004: Support Awaitables (pep 492) in @asyncio.coroutine decorator https://hg.python.org/cpython/rev/6c53591d589b -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Roundup Robot added the comment: New changeset 5f1e24f083c7 by Yury Selivanov in branch '3.5': Issue 24004: Add a unittest for @asyncio.coroutine supporting Awaitables https://hg.python.org/cpython/rev/5f1e24f083c7 New changeset 9d261141eb0c by Yury Selivanov in branch 'default': Issue 24004: Add a unittest for @asyncio.coroutine supporting Awaitables https://hg.python.org/cpython/rev/9d261141eb0c -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Changes by Yury Selivanov yseliva...@gmail.com: -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: I found one more place in asyncio.coroutines, around line 190 in the coroutine() decorator: if inspect.isgeneratorfunction(func): coro = func else: @functools.wraps(func) def coro(*args, **kw): res = func(*args, **kw) if isinstance(res, futures.Future) or inspect.isgenerator(res): res = yield from res return res The wrapped isgenerator() check should be replaced by an Awaitable ABC check, e.g. this works for me: res = func(*args, **kw) if isinstance(res, futures.Future) or inspect.isgenerator(res): res = yield from res +else: +await_res = getattr(res, '__await__', None) +if await_res is not None: +res = yield from await_res() return res -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Yury Selivanov added the comment: What inspect.isgeneratorfunction(func) returns for Cython generators? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Yury Selivanov added the comment: This issue was resolved in https://github.com/python/asyncio/commit/3a09a93277afc2cdb43badf92a2c85c2789813f6. -- resolution: - fixed stage: - resolved status: open - closed versions: -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: I was (silently) hoping that this patching would eventually not be necessary anymore because the one place (currently inspect.isgenerator()) would be adapted to check for the generator protocol rather than the generator type. But that was going to go into a separate ticket. :) I'm not sure inspect.isgenerator() is the right place, though, as the module tends to deal with types, not protocols. I think the right fix overall would be a Generator ABC class that defines the protocol. What Cython does now in order to make asyncio work with Cython compiled generators is this: https://github.com/cython/cython/blob/4af42443bd37f6207143f8870904f780a65bb3e3/Cython/Utility/Generator.c#L824 https://github.com/cython/cython/blob/4af42443bd37f6207143f8870904f780a65bb3e3/Cython/Utility/Generator.c#L906 Aweful, but currently required due to the type check, which prevents objects that implement the generator protocol from being handled correctly by asyncio. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Stefan Behnel added the comment: I created issue 24018 for adding a Generator ABC to collections.abc. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
New submission from Stefan Behnel: asyncio/coroutines.py contains this code: _COROUTINE_TYPES = (types.GeneratorType, CoroWrapper) def iscoroutine(obj): Return True if obj is a coroutine object. return isinstance(obj, _COROUTINE_TYPES) In other places, it uses inspect.isgenerator() to do the same thing. This is inconsistent and should be changed. Code that wants to patch inspect.isgenerator() in order to support other generator types shouldn't also have to patch asyncio directly, and code that wants to support other generator types in asyncio shouldn't have to patch both places either. -- components: asyncio messages: 241506 nosy: gvanrossum, haypo, scoder, yselivanov priority: normal severity: normal status: open title: avoid explicit generator type check in asyncio type: behavior versions: Python 3.4, Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24004] avoid explicit generator type check in asyncio
Guido van Rossum added the comment: Uh, wait. Who's patching anything? That breaks the warranty. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24004 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
