[issue24011] Add error checks to PyInit_signal()

STINNER Victor added the comment: There is a regression related to reference count: see bpo-38037. -- nosy: +vstinner ___ Python tracker ___

[issue24011] Add error checks to PyInit_signal()

Berker Peksag added the comment: New changeset 9541bd321a94f13dc41163a5d7a1a847816fac84 by Berker Peksag (Joannah Nanjekye) in branch 'master': bpo-24011: Use PyModule_Add{Object,IntMacro} in PyInit__signal() (GH-12765)

[issue24011] Add error checks to PyInit_signal()

Berker Peksag added the comment: Thank you, Joannah. There's no need to backport PR 12765 to maintenance branches, so I'm closing this issue as 'fixed'. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.7

[issue24011] Add error checks to PyInit_signal()

Joannah Nanjekye added the comment: @berkerpeksag I made the requested changes on the PR. PTAL. -- nosy: +nanjekyejoannah ___ Python tracker ___

[issue24011] Add error checks to PyInit_signal()

Change by Joannah Nanjekye : -- pull_requests: +12693 stage: needs patch -> patch review ___ Python tracker ___ ___

[issue24011] Add error checks to PyInit_signal()

Change by Cheryl Sabella : -- stage: patch review -> needs patch versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5 ___ Python tracker ___

[issue24011] Add error checks to PyInit_signal()

Berker Peksag added the comment: All of the PyModule_AddIntMacro() changes have already been applied in https://github.com/python/cpython/commit/6782b14bcba612e4a39e41992c77306217b91e30. The remaining parts are: -x = PyLong_FromLong((long)NSIG); -if (!x || PyDict_SetItemString(d,

[issue24011] Add error checks to PyInit_signal()

New submission from Christian Heimes: The init function of the signal module fails to check for errors in a couple of places. The patch replaces PyDict_SetItemString() calls with PyModule_AddIntMacro() and error checks. An exception is unlikely so I'm OK when the patch just lands in 3.4 and