[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Robert Collins]

Robert Collins added the comment:

Debian is green again and I think windows will do so to.

--
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Robert Collins]

Robert Collins added the comment:

So it looks like one failure is:
FAIL: test_getline (test.test_linecache.GoodUnicode)
--
Traceback (most recent call last):
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_linecache.py",
 line 63, in test_getline
self.assertEqual(line, cached_line)
AssertionError: 'á\n' != '�\n'
- á
+ �

and the other is:


==
ERROR: test_getline (test.test_linecache.GoodUnicode)
--
Traceback (most recent call last):
  File 
"/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/test/test_linecache.py",
 line 58, in test_getline
for index, line in enumerate(fp):
  File 
"/home/dje/cpython-buildarea/3.x.edelsohn-debian-z/build/Lib/encodings/ascii.py",
 line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 0: ordinal 
not in range(128)

We need to figure out if the failure is spurious/local capabilities (e.g. we 
should skip the test here) or a bug in the test. Where can I find out more 
about the config of the buildbots?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Robert Collins]

Robert Collins added the comment:

I can't see how the patch could have caused the 
Traceback (most recent call last):
  File 
"D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_symbol.py",
 line 44, in test_real_grammar_and_symbol_file
os.stat(TEST_PY_FILE)))
AssertionError: False is not true : symbol stat: os.stat_result(st_mode=33206, 
st_ino=108649341010373284, st_dev=164288, st_nlink=1, st_uid=0, st_gid=0, 
st_size=2095, st_atime=1438992962, st_mtime=1438992962, st_ctime=1438992962)
test_py stat: os.stat_result(st_mode=33206, st_ino=71213169107987373, 
st_dev=164288, st_nlink=1, st_uid=0, st_gid=0, st_size=2209, 
st_atime=1439969830, st_mtime=1439969831, st_ctime=1439969830)


failure, so I'm going to ignore that - its a size change in the output file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David Edelsohn]

David Edelsohn added the comment:

Also

http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/2/steps/test/logs/stdio

http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/2

Comments

Issue #24054: decouple linecache tests from inspect tests

Patch from David D. Riddle

Changed files

Lib/test/test_linecache.py

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[R. David Murray]

R. David Murray added the comment:

Example:

http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/10098/steps/test/logs/stdio

--
nosy: +r.david.murray
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David Edelsohn]

Changes by David Edelsohn :


--
nosy: +David.Edelsohn -David Edelsohn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David Edelsohn]

David Edelsohn added the comment:

This patch causes a new failure on many of the buildbots.

--
nosy: +David Edelsohn

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Robert Collins]

Robert Collins added the comment:

Thank you for the patch; sorry it took me so long to get to it - been working 
on a backlog of patch review.

--
resolution:  -> fixed
stage:  -> resolved
status: open -> closed
versions: +Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Roundup Robot]

Roundup Robot added the comment:

New changeset fc56a0300cd4 by Robert Collins in branch 'default':
Issue #24054: decouple linecache tests from inspect tests
https://hg.python.org/cpython/rev/fc56a0300cd4

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David D. Riddle]

David D. Riddle added the comment:

Here is another patch. I fixed a bug in GetLineTestsBadData.test_getline and 
refactored the code. I think everything is good now.

As for the ResourceWarnings they are not caused by linecache. The problem is 
with tokenize.open (See http://bugs.python.org/issue23840).

--
Added file: http://bugs.python.org/file39295/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David D. Riddle]

David D. Riddle added the comment:

I have made the changes you suggested. Please tell me if any further changes 
are needed.

> The unclosed file suggests a cleanup bug in linecache which we should
> fix for hygiene, but is separate :)

Should I file a bug report?

--
Added file: http://bugs.python.org/file39291/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David D. Riddle]

David D. Riddle added the comment:

I have made the changes you suggested. Please look at lines 87-97. I am not 
certain if that is correct behavior. I was surprised that a SyntaxError is 
thrown in addition to the UnicodeDecodeError when linecache.getlines takes a 
file with bad unicode. Please tell me if this or other parts of the patch need 
work.

--
Added file: http://bugs.python.org/file39262/new.mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[Robert Collins]

Robert Collins added the comment:

Thanks, I shall look at this Monday.

--
nosy: +rbcollins

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

[David D. Riddle]

New submission from David D. Riddle:

test_linecache.py reads from three files namely inspect_fodder.py, 
inspect_fodder2.py, and mapping_tests.py. It reads the py files directly as 
text files. This patch copies these files to linecache_fodder, 
linecache_fodder2, and linecache_mapping_fodder respectively, and updates 
test_linecache.py accordingly.

The reason I do this is so that the these files are not compiled. This is 
desirable for me because I use linecache2 on python 2.7. Python 2.7 can not 
compile inspect_fodder2.py nor is it necessary as this file is only used as a 
text file never as an object file in the test_linecache.py tests.

This issue came up for me when I attempted to make an RPM out of linecache2. 
rpmbuild compiles all py files in the rpm and fails when it tries to compile 
inspect_fodder2.py. If these files have the .py removed from the test files 
then they will not be compiled which fixes my issue. Nor do they need to be 
compiled to successfully run the test_linecache.py tests.

--
components: Tests
files: mywork.patch
keywords: patch
messages: 241955
nosy: ddriddle
priority: normal
severity: normal
status: open
title: Invalid syntax in inspect_fodder2.py (on Python 2.x)
type: compile error
Added file: http://bugs.python.org/file39198/mywork.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com