[issue24136] document PEP 448: unpacking generalization

[Martin Panter]

Martin Panter added the comment:

Thanks for the review. I committed my patch in the hope that it makes it into 
3.5.2, but if people want to suggest further improvements etc that is okay.

--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Roundup Robot]

Roundup Robot added the comment:

New changeset a7e04b4e51b2 by Martin Panter in branch '3.5':
Issue #24136: Document generalized unpacking, PEP 448
https://hg.python.org/cpython/rev/a7e04b4e51b2

New changeset 4cf3389cd8e6 by Martin Panter in branch 'default':
Issue #24136: Merge unpacking doc from 3.5
https://hg.python.org/cpython/rev/4cf3389cd8e6

New changeset 2c10f0e92256 by Martin Panter in branch 'default':
Issue #24136: Adjust f-strings doc for interable unpacking
https://hg.python.org/cpython/rev/2c10f0e92256

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

Thanks for writing a better patch. The patch looks good to me and it builds 
correctly.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Martin Panter]

Martin Panter added the comment:

Here is a new patch that also updates the documentation for list etc displays 
as well as function calls. Let me know what you think.

The 3.5 What’s New notes were written separately; Neil’s patch was never 
applied. But I have rescued his update for functools.partial() in my new patch.

While experimenting with the current behaviour, I found some surprising 
inconsistencies. The following syntaxes are allowed:

>>> x, *y
>>> a = x, *y
>>> f"{x, *y}"  # New in 3.6
>>> async def f(): await x, *y

But the following all produce “SyntaxError: invalid syntax”:

>>> a += x, *y
>>> eval("x, *y")
>>> def f(): return x, *y
>>> def f(): yield x, *y
>>> for i in x, *y: ...

Also, the expressions allowed for unpacking in general are more limited than in 
function calls:

>>> f(x, *y == z)  # Allowed
>>> (x, *y == z)
SyntaxError: invalid syntax

--
Added file: http://bugs.python.org/file43339/unpacking-doc.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Antoine Pitrou]

Changes by Antoine Pitrou :


--
nosy:  -pitrou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Martin Panter]

Martin Panter added the comment:

Thanks for helping with this Jelle.

The documentation of unpacking sequences vs iterables was adjusted in 3.6 as 
part of Issue 23275. I guess part of revision 8a0754fed986 should be extracted 
to 3.5 as well.

Looking at the function call syntax, positional and starred should be optional. 
I don’t think your syntax would allow print(file=stderr).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

This updates reference_calls_syntax_update.diff. The previous patch's grammard 
had a mistake; it was missing commas between arguments.

I believe all other patches in this diff are now obsolete.

--
Added file: http://bugs.python.org/file43302/issue24136-expressions.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

Here's what I found reviewing what needs to be done here:

- Neil's What's New patch apparently made it into the 3.5 release notes.
- moigagoo's two patches haven't been committed. The text of both looks ok to 
me, but the patches don't apply cleanly.

Other areas that still need updates:
- https://docs.python.org/3/reference/expressions.html#list-displays and the 
sections for set, dict, and tuple displays need to mention PEP 448-style syntax.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Zachary Ware]

Changes by Zachary Ware :


--
hgrepos:  -336

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Brett Cannon]

Changes by Brett Cannon :


--
nosy:  -brett.cannon

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Berker Peksag]

Changes by Berker Peksag :


--
Removed message: http://bugs.python.org/msg263250

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Berker Peksag]

Berker Peksag added the comment:

supriyanto maftuh,st, please don't play with tracker items.

--
components:  -Benchmarks, Build, IO, Unicode, Windows, XML, email
versions:  -Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[supriyanto maftuh,st]

supriyanto maftuh,st added the comment:

Hy

--
components: +Benchmarks, Build, IO, Unicode, Windows, XML, email
hgrepos: +336
nosy: +barry, brett.cannon, ezio.melotti, haypo, paul.moore, pitrou, 
r.david.murray, steve.dower, supriyanto maftuh, supriyanto maftuh,st, 
tim.golden, zach.ware
versions: +Python 2.7, Python 3.2, Python 3.3, Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Terry J. Reedy]

Terry J. Reedy added the comment:

It is now 10 months and 2 releases since the rather large code patch.  
Documenting the extensive changes does not seem easy to me ;-).  Certainly, a 
beginner needs feedback.

--
nosy: +terry.reedy

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Berker Peksag]

Changes by Berker Peksag berker.pek...@gmail.com:


--
nosy: +berker.peksag
stage: needs patch - patch review
versions: +Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Konstantin Molchanov]

Changes by Konstantin Molchanov moiga...@live.com:


Added file: http://bugs.python.org/file39919/replace_sequence_with_iterable.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Konstantin Molchanov]

Konstantin Molchanov added the comment:

I've updated the Calls syntax reference in reference/expressions and the 
assignment object description in reference/simple_stmts.

Please tell me if I'm generally doing OK. If I'm not, please guide me to the 
right direction.

--
Added file: http://bugs.python.org/file39918/reference_calls_syntax_update.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Neil Girdhar]

Neil Girdhar added the comment:

Copied from closed issue 24240:

Since Grammar/Grammar relies on semantic postprocessing in ast.c,
it would be nice to have an update of the (human readable) Grammar
in the language reference docs.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Martin Panter]

Martin Panter added the comment:

FWIW, I still emails from the tracker, even the ones with my own comments and 
changes. All I can suggest is check the address you have set, check for spam, 
etc.

I don’t @mentioning will do anything here. But as long as the person is in the 
nosy list they _should_ get an email (in theory :).

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Konstantin Molchanov]

Konstantin Molchanov added the comment:

@vadmium thanks for the assistance! I'll kick off with the reference then.

P.S. Am I the only one who doesn't receive any emails from the tracker? I never 
got the registration link or a follow-up notification from this issue. Am I 
missing something?

P.P.S. I'm not yet familiar with the local etiquette, so please forgive me if 
I'm unintentionally breaking some rules. Is @mentioning OK?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Neil Girdhar]

Neil Girdhar added the comment:

I don't receive emails from the tracker anymore either and I have no idea why 
that is.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448: unpacking generalization

[Martin Panter]

Martin Panter added the comment:

Yes I think it is expected and documented that the leftovers are turned into a 
list. See https://docs.python.org/3.5/reference/simple_stmts.html#index-6. I 
originally had similar confusion, expectating the starred target to become a 
tuple, because people often use tuple-like syntax, but:

 generator_expression = (2**i for i in range(4))
 (one, *a_list, eight) = generator_expression
 a_list  # Not a tuple!
[2, 4]

One thing in the section I linked above that should also be fixed is that the 
assigned object may be any iterable, not just a sequence.

About changing the tutorial, just be careful you don’t add unnecessary 
complication too early. The original * and ** syntax for function parameters is 
not mentioned until 
https://docs.python.org/3.5/tutorial/controlflow.html#more-on-defining-functions.
 Later, argument unpacking: 
https://docs.python.org/3.5/tutorial/controlflow.html#unpacking-argument-lists.
 Assignment unpacking doesn’t seem to mentioned at all (not that I am saying it 
should be). It might be higher priority to update the main reference 
documentation first.

--
title: document PEP 448 - document PEP 448: unpacking generalization

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448

[Neil Girdhar]

Neil Girdhar added the comment:

Simplified functools.partial documentation.

--
Added file: http://bugs.python.org/file39561/wn2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448

[Neil Girdhar]

Changes by Neil Girdhar mistersh...@gmail.com:


Added file: http://bugs.python.org/file39562/wn2.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448

[Neil Girdhar]

Neil Girdhar added the comment:

Just updated the what's new.  Also, thank you for adding my name to 
Misc/Acks.  Should we also add Joshua Landau's name?  He helped me quite a bit 
with the implementation, and he wrote the PEP.

--
keywords: +patch
nosy: +neil.g
Added file: http://bugs.python.org/file39370/whatsnew.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448

[Martin Panter]

Changes by Martin Panter vadmium...@gmail.com:


--
nosy: +vadmium

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24136] document PEP 448

[Benjamin Peterson]

New submission from Benjamin Peterson:

PEP 448 has been implemented (#2292), but the documentation hasn't been 
updated. Updating the documentation will improve looking through

Doc/reference/*

and making sure the documentation (and grammar) for calls and assignments is 
updated for PEP 448's new syntax.

I'm marking this as easy because it might be a good first bug.

--
assignee: docs@python
components: Documentation
keywords: easy
messages: 242668
nosy: benjamin.peterson, docs@python
priority: high
severity: normal
stage: needs patch
status: open
title: document PEP 448
type: enhancement
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24136
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com