[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: The net effect of this issue: pyshell.main calls NoDefaultRoot() when running normally, when using a subprocess and testing is not set. It does not call it when in -n mode since that would affect users. idle_test.htest calls NoDefaultRoot() unconditionall

[issue24137] Force not using _default_root in IDLE

Roundup Robot added the comment: New changeset a6a248479b66 by Terry Jan Reedy in branch 'default': Issue #27611, #24137: Only change tkinter when easily restored. https://hg.python.org/cpython/rev/a6a248479b66 -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

Roundup Robot added the comment: New changeset 5c76f787e695 by Terry Jan Reedy in branch 'default': Issue #24137, issue #27611: Restore tkinter after test_idle. https://hg.python.org/cpython/rev/5c76f787e695 -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

Martin Panter added the comment: It seems this change causes test_tix to fail for me; see Issue 27611 -- nosy: +martin.panter ___ Python tracker ___ _

[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: Using Rietveld to make a 1-2 diff for each file, it appears you made 3 changes. I incorporated 2, and missed 1 (which you just pushed). I believe I incorporated your changes by hand because I had already made additional changes myself. I suspect that at that

[issue24137] Force not using _default_root in IDLE

Serhiy Storchaka added the comment: You have missed my changes in nodefaultroot2.diff. -- ___ Python tracker ___ ___ Python-bugs-list

[issue24137] Force not using _default_root in IDLE

Roundup Robot added the comment: New changeset a8d611eb6173 by Serhiy Storchaka in branch 'default': Issue #24137: Fixed IDLE on Linux with tkinter default root disabled. https://hg.python.org/cpython/rev/a8d611eb6173 -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue24137] Force not using _default_root in IDLE

Roundup Robot added the comment: New changeset 064b29dde096 by Terry Jan Reedy in branch 'default': Issue #24137: Run IDLE, test_idle, and htest with tkinter default root disabled. https://hg.python.org/cpython/rev/064b29dde096 -- nosy: +python-dev __

[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: Conditioned NoDefaultRoot() on use_subprocess. Ran through menu. Will push soon after rechecking patches with Rietveld. Thanks for the additional review. I don't know that this caught any real bugs in IDLE itself. But many of the htests needed upgrading t

[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: I made htest run without default root, just list test_idel, and found a few more. I grepped for 'Toplevel()'. Also for bad Tk() calls. I still need to move the call in pyshell and check this over. But I think it close. -- Added file: http://bugs.py

[issue24137] Force not using _default_root in IDLE

Serhiy Storchaka added the comment: And I thing changes to tests can be applied to all versions (especially since they become diverge), but NoDefaultRoot() should be called in IDLE only in 3.6. -- ___ Python tracker

[issue24137] Force not using _default_root in IDLE

Serhiy Storchaka added the comment: I ran IDLE and tests and found yet few needed changes. NoDefaultRoot() should be called only if run IDLE with a subprocess support. -- Added file: http://bugs.python.org/file43489/nodefaultroot2.diff ___ Python tra

[issue24137] Force not using _default_root in IDLE

Terry J. Reedy added the comment: Time to do it, at least for tests. I think patch is ready to push, with running without default root disabled until I do more testing. In particular, reread in Rietveld, do suggested actions when run through htest, and try all menu items. -- assigne

[issue24137] Force not using _default_root in IDLE

Serhiy Storchaka added the comment: What your thoughts about this Terry? -- stage: -> needs patch ___ Python tracker ___ ___ Python-b

[issue24137] Force not using _default_root in IDLE

New submission from Serhiy Storchaka: Perhaps explicitly calling NoDefaultRoot() in IDLE will help to catch some possible bugs (in IDLE or in Tkinter). It should be called only when IDLE is ran in subprocess mode, so it will not affect user code that uses Tkinter. _default_root is used mainly