[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Roundup Robot added the comment: New changeset 7adc1d24d05b by Victor Stinner in branch 'default': Closes #25645: Fix a reference leak introduced by change bc5894a3a0e6 of the https://hg.python.org/cpython/rev/7adc1d24d05b -- ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: Serhiy Storchaka added the comment: > Could you please look at proposed documentation changes? Sure, done. -- ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: Thanks. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: Documentation patch updated. -- Added file: http://bugs.python.org/file40771/pickle_new_ex_protocol_2_doc_2.patch ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: pickle_new_ex_protocol_2_doc_2.patch looks good to me. -- ___ Python tracker ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Roundup Robot added the comment: New changeset de982d8b7b15 by Serhiy Storchaka in branch 'default': Issue #24164: Document changes to __getnewargs__ and __getnewargs_ex__. https://hg.python.org/cpython/rev/de982d8b7b15 -- ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Roundup Robot added the comment: New changeset 288953a787ce by Victor Stinner in branch 'default': Issue #24164: Fix test_pyclbr https://hg.python.org/cpython/rev/288953a787ce -- ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: > New changeset 288953a787ce by Victor Stinner in branch 'default': > Issue #24164: Fix test_pyclbr Another fix would be to accept functools.partial type, but it looks like the test wants to exclude symbols which comes from other modules. --

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: At least, test_pyclbr was fixed by my change. Most 3.x buildbots are green again. -- ___ Python tracker ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: Thank you Victor for fixing test_pyclbr. test_pyclbr looks fragile and may be there are bugs in pyclbr itself. But this is different issue. Could you please look at proposed documentation changes? -- ___ Python

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Changes by Arfrever Frehtes Taifersar Arahesis : -- nosy: +Arfrever ___ Python tracker ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: Buildbots failed. http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/2807/steps/test/logs/stdio == FAIL: test_reduce (test.test_descr.PicklingTests)

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Roundup Robot added the comment: New changeset df33dbbef7bb by Serhiy Storchaka in branch 'default': Issue #24164: Fixed test_descr: __getnewargs_ex__ now is supported in protocols 2 and 3. https://hg.python.org/cpython/rev/df33dbbef7bb -- ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: Thank you Victor. Tests are fixed. I think the documentation needs to be updated. Here is a patch for pickle documentation. -- stage: resolved -> patch review Added file: http://bugs.python.org/file40751/pickle_new_ex_protocol_2_doc.patch

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Roundup Robot added the comment: New changeset bc5894a3a0e6 by Serhiy Storchaka in branch 'default': Issue #24164: Objects that need calling ``__new__`` with keyword arguments, https://hg.python.org/cpython/rev/bc5894a3a0e6 -- nosy: +python-dev ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: Thank you for your review Victor. -- assignee: -> serhiy.storchaka resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Serhiy Storchaka added the comment: > Hum, can you please write a short example of such class which can only be > pickled by the protocol 4 currently? Just for my information. For now there are no such classes in the stdlib. No one implements __getnewargs_ex__. But an alternative

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

STINNER Victor added the comment: "Pickling of objects of classes whose __new__ mandates the use of keyword-only arguments is supported with protocol 4 (using a new opcode NEWOBJ_EX)." Hum, can you please write a short example of such class which can only be pickled by the protocol 4

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

Changes by Serhiy Storchaka : -- versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue24164] Support pickling objects with __new__ with keyword arguments with protocol 2+

New submission from Serhiy Storchaka: Pickling of objects of classes whose __new__ mandates the use of keyword-only arguments is supported with protocol 4 (using a new opcode NEWOBJ_EX). But it is possible to implement this feature with protocol 2+ (less efficiently than with NEWOBJ_EX).