[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Change by Jason R. Coombs :


--
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Jason R. Coombs  added the comment:


New changeset f289084c83190cc72db4a70c58f007ec62e75247 by Jason R. Coombs in 
branch 'master':
bpo-24209: In http.server script, rely on getaddrinfo to bind to preferred 
address based on the bind parameter. (#11767)
https://github.com/python/cpython/commit/f289084c83190cc72db4a70c58f007ec62e75247


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Change by Jason R. Coombs :


--
pull_requests: +11726, 11727, 11728
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Change by Jason R. Coombs :


--
pull_requests: +11726
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Change by Jason R. Coombs :


--
pull_requests: +11726, 11727
stage: resolved -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Jason R. Coombs  added the comment:

I don't believe the current patch as accepted has the right behaviors. First 
off, the default behavior, which indicates "all interfaces" only binds to IPv4 
interfaces. Additionally, "-b localhost" only binds to IPv4 localhost.

Ideally, the bind should happen on all stacks unless a specific stack is 
indicated.

--
assignee:  -> jason.coombs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Lisa Roach]

Change by Lisa Roach :


--
stage: patch review -> resolved

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Gregory P. Smith]

Change by Gregory P. Smith :


--
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Lisa Roach]

Lisa Roach  added the comment:

Looks like the original author isn't around anymore (feel free to chime in if 
you are, Link!), so I went ahead and made a PR. I added a quick unit test, it's 
not much but more than nothing, plus updated the documentation.

--
nosy: +lisroach

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Lisa Roach]

Change by Lisa Roach :


--
pull_requests: +9840
stage: test needed -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Mayank Asthana]

Change by Mayank Asthana :


--
nosy: +masthana

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Radek Podgorny]

Change by Radek Podgorny :


--
nosy: +rpodgorny

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Jason R. Coombs  added the comment:

>From what I can tell, there's not currently any tests for the behavior of 
>`http.server` as a script, and that sounds like a non-trivial behavior to 
>test. I agree documentation updates for this change are essential, but I'd 
>suggest a test is too high a burden to ask for a change like this when there 
>aren't already tests exercising the related functionality.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Jason R. Coombs]

Change by Jason R. Coombs :


--
nosy: +jason.coombs

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Josh Lee]

Changes by Josh Lee :


--
nosy: +jleedev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Berker Peksag]

Changes by Berker Peksag :


--
nosy: +berker.peksag
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Martin Panter]

Martin Panter added the comment:

I am no IPv6 expert, but this looks like a reasonable first approximation. The 
“http.server” module documentation should also be updated to say IPv6 addresses 
are supported on the command line, and I guess there should be a test case 
added.

But maybe see Lib/smtpd.py line 657 for how this is done in a more general way 
for the SMTP server module (Issue 14758), using getaddrinfo(). There is also 
Issue 20215 proposing to do something equivalent in the lower level 
“socketserver” module, which would probably make this change redundant.

It would also be nice for it to bind to both IPv4 and IPv6 if possible, but 
that is apparently not easy to do cross platform; see Issue 3213.

--
stage:  -> test needed
versions:  -Python 3.4

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Demian Brecht]

Changes by Demian Brecht :


--
nosy: +demian.brecht

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Martin Panter]

Changes by Martin Panter :


--
nosy: +vadmium

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24209] Allow IPv6 bind in http.server

[Link Mauve]

New submission from Link Mauve:

When running `python -m http.server -b ::` (or any other IPv6), I’d expect 
people to be able to download from my IPv6.

This patch fixes that issue.

I also tested it on a dual-stack kernel, IPv4 requests work just fine and 
appear as :::127.0.0.1 for example.

--
components: Library (Lib)
files: ipv6.patch
keywords: patch
messages: 243317
nosy: Link Mauve
priority: normal
severity: normal
status: open
title: Allow IPv6 bind in http.server
type: enhancement
versions: Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file39390/ipv6.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com