[issue24217] O_RDWR undefined in mmapmodule.c

[Jeffrey Armstrong]

Jeffrey Armstrong added the comment:

There is a patch attached to this report for greater than 2 months. Should I 
mark this as won't fix?

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24217] O_RDWR undefined in mmapmodule.c

[Roundup Robot]

Roundup Robot added the comment:

New changeset 1838f37a8d9e by Benjamin Peterson in branch '3.4':
include fcntl.h on all *nix platforms (closes #24217)
https://hg.python.org/cpython/rev/1838f37a8d9e

New changeset 25ba5e7af08a by Benjamin Peterson in branch '3.5':
Merge 3.4 (#24217)
https://hg.python.org/cpython/rev/25ba5e7af08a

New changeset 4ed9cc2203b3 by Benjamin Peterson in branch 'default':
merge 3.5 (#24217)
https://hg.python.org/cpython/rev/4ed9cc2203b3

New changeset 2e635a0e0207 by Benjamin Peterson in branch '2.7':
include fcntl.h on all *nix platforms (closes #24217)
https://hg.python.org/cpython/rev/2e635a0e0207

--
nosy: +python-dev
resolution:  - fixed
stage:  - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24217] O_RDWR undefined in mmapmodule.c

[Jeffrey Armstrong]

New submission from Jeffrey Armstrong:

While compiling on Linux/x86 with Open Watcom, I've run into the following at 
link time in Modules/mmapmodule.c:

./Modules/mmapmodule.c(1223): Error! E1011: Symbol 'O_RDWR' has not been 
declared

The constant isn't defined because fcntl.h isn't included.  Looking at the top 
of the file, it appears that, for the Apple platform only, this header is 
included, but no others.

In order to support more runtime libraries outside of GNU libc, I would suggest 
including fcntl.h for all UNIX-y platforms, especially because the POSIX 
standard dictates that this constant be defined in fcntl.h.  I don't know how 
it finds its way in under GCC/GNU libc, but an explicit include might be better.

--
components: Extension Modules
files: mmapmodule.py3.5.0a3.diff
keywords: patch
messages: 243404
nosy: Jeffrey.Armstrong
priority: normal
severity: normal
status: open
title: O_RDWR undefined in mmapmodule.c
type: compile error
versions: Python 3.5
Added file: http://bugs.python.org/file39407/mmapmodule.py3.5.0a3.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24217] O_RDWR undefined in mmapmodule.c

[Jeffrey Armstrong]

Jeffrey Armstrong added the comment:

Indeed, I agree.  Let's try this new patch.

--
Added file: 
http://bugs.python.org/file39408/mmapmodule.py3.5.0a3.HAVE_FCNTL_H.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24217] O_RDWR undefined in mmapmodule.c

[Christian Heimes]

Christian Heimes added the comment:

I think it's more portable with a #ifdef HAVE_FCNTL_H block around the include.

--
nosy: +christian.heimes

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24217] O_RDWR undefined in mmapmodule.c

[Jeffrey Armstrong]

Changes by Jeffrey Armstrong jeffrey.armstr...@approximatrix.com:


Removed file: http://bugs.python.org/file39407/mmapmodule.py3.5.0a3.diff

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24217
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com