[issue2422] Automatically disable pymalloc when running under valgrind
Changes by Robert Collins robe...@robertcollins.net: -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Benjamin Peterson benja...@python.org added the comment: Thank you. Applied in r76644. -- nosy: +benjamin.peterson resolution: - accepted status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Changes by Dave Malcolm dmalc...@redhat.com: -- nosy: +dmalcolm ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
James Henstridge ja...@jamesh.id.au added the comment: Attached is an updated version of the patch against trunk (2.7). It simply fixes the conflicts that have occurred since the previous patch. Added file: http://bugs.python.org/file12935/disable-pymalloc-on-valgrind-py27.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2422 ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Christian Heimes [EMAIL PROTECTED] added the comment: James Henstridge schrieb: James Henstridge [EMAIL PROTECTED] added the comment: There are probably a few other performance optimisations that would be good to turn off when running under valgrind. A big one is the tuple cache: if there are tuple reference counting issues, they won't necessarily be seen by valgrind if the tuple is kept and reused rather than being freed. The tuple cache can't be disabled entirely. Some parts of Python and some third party modules may depend on the fact that an empty tuple () is a singleton in Python. The tuple cache could be reduced to empty tuple and some other caches like the list and dict cache could be disabled entirely. Christian __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
James Henstridge [EMAIL PROTECTED] added the comment: There are probably a few other performance optimisations that would be good to turn off when running under valgrind. A big one is the tuple cache: if there are tuple reference counting issues, they won't necessarily be seen by valgrind if the tuple is kept and reused rather than being freed. __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
James Henstridge [EMAIL PROTECTED] added the comment: An updated version of the patch. The previous ones were missing the valgrind check, resulting in the pymalloc code paths being executed (which in turn cause unintialised read warnings from valgrind). Added file: http://bugs.python.org/file9872/disable-pymalloc-on-valgrind-py26.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Lauro Moura [EMAIL PROTECTED] added the comment: Here's a patch with James changes to obmalloc and a --with-valgrind option in configure.in. -- nosy: +lauromoura Added file: http://bugs.python.org/file9835/disable-pymalloc-on-valgrind-26.diff __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
James Henstridge [EMAIL PROTECTED] added the comment: Here's the updated version of my patch (the obmalloc.c bits applied without conflicts to the newer source tree). The configure changes are a bit different to Lauro's ones, in that they check for the existence of the valgrind/valgrind.h header if Valgrind support was requested. Added file: http://bugs.python.org/file9837/disable-pymalloc-on-valgrind-py26.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Christian Heimes [EMAIL PROTECTED] added the comment: Please provide a patch for Python 2.6 that includes a ./configure --with-valgrind option. We may consider such a patch for 2.6 and 3.0 but definitely not for 2.5. -- nosy: +tiran priority: - normal versions: +Python 2.6 -Python 2.5 __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
New submission from James Henstridge [EMAIL PROTECTED]: When I want to use valgrind to check for leaks in a Python program (or test suite), I generally want pymalloc disabled. When not running valgrind I generally want it enabled. Attached is a patch that automatically bypasses the pymalloc code when running under valgrind but leaves it enabled overwise. It is controlled by a WITH_VALGRIND #define, but I haven't updated the configure script to allow turning it on. I also haven't done much in the way of profiling to see what the overhead is when not running under valgrind. -- components: Interpreter Core files: disable-pymalloc-on-valgrind.patch keywords: patch messages: 64052 nosy: jamesh severity: normal status: open title: Automatically disable pymalloc when running under valgrind type: feature request versions: Python 2.5 Added file: http://bugs.python.org/file9765/disable-pymalloc-on-valgrind.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Changes by James Henstridge [EMAIL PROTECTED]: Added file: http://bugs.python.org/file9781/disable-pymalloc-on-valgrind-v3.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue2422] Automatically disable pymalloc when running under valgrind
Changes by James Henstridge [EMAIL PROTECTED]: Removed file: http://bugs.python.org/file9780/disable-pymalloc-on-valgrind-v2.patch __ Tracker [EMAIL PROTECTED] http://bugs.python.org/issue2422 __ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
