[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Roundup Robot]

Roundup Robot added the comment:

New changeset bf7ef3bd9a09 by Victor Stinner in branch 'default':
Issue 24297: Fix test_symbol on Windows
https://hg.python.org/cpython/rev/bf7ef3bd9a09

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Yury Selivanov]

Yury Selivanov added the comment:

Marius, thanks for reporting the bug and review!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Yury Selivanov]

Changes by Yury Selivanov yseliva...@gmail.com:


--
resolution:  - fixed
stage: patch review - resolved
status: open - closed

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Roundup Robot]

Roundup Robot added the comment:

New changeset a95d0dd3c2b1 by Yury Selivanov in branch 'default':
Issue 24297: Add a unittest that Lib/symbol.py is in sync with Grammar
https://hg.python.org/cpython/rev/a95d0dd3c2b1

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[R. David Murray]

R. David Murray added the comment:

It is automatically generated in that it isn't hand-written.  On the other 
hand, it isn't automatically generated in the sense of being part of the make 
process, ./python symbol.py is supposed to be run by hand when it is 
appropriate.

A bit ago someone wrote tests for keyword.py that among other things made sure 
we didn't forget to update it when needed.  Someone needs to write a similar 
test for symbol, it looks like.

Whether or not one or both of these could be/should be incorporated into make 
(now that we have 'make touch' to deal with the consequences) is a separate 
question.  As to why it is checked in, we check in almost all the build 
artifacts previous to the compile stage, so that there is no need to have an 
already-built python to build python from source.

--
nosy: +benjamin.peterson, r.david.murray

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Marius Gedminas]

New submission from Marius Gedminas:

While investigating 
https://bitbucket.org/pypa/setuptools/issue/388/install-from-sdist-fails-on-python-350b1
 I noticed that Grammar/Grammar changed in 3.5, but Lib/symbol.py wasn't 
updated.

I'm not familiar with the CPython parser, but I suspect that 
adding/removing/splitting grammar rules causes the nonterminal symbol IDs to 
shift, which ought to require an update in symbol.py.

Huh.  Now I see a comment in the file says it is automatically generated, but 
in that case why wasn't that done when I did 'hg pull -u  make  make 
install'?  Why is it checked into source control?

--
components: Library (Lib)
messages: 244160
nosy: mgedmin
priority: normal
severity: normal
status: open
title: Lib/symbol.py is out of sync with Grammar/Grammar
versions: Python 3.5

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Roundup Robot]

Roundup Robot added the comment:

New changeset 843fe7e831a8 by Yury Selivanov in branch '3.5':
Issue 24297: Update symbol.py. See also issue 24017.
https://hg.python.org/cpython/rev/843fe7e831a8

New changeset 87509d71653b by Yury Selivanov in branch 'default':
Issue 24297: Update symbol.py. See also issue 24017.
https://hg.python.org/cpython/rev/87509d71653b

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Yury Selivanov]

Yury Selivanov added the comment:

Attached is a new unittest to make sure that symbol.py is always updated.  
Essentially it's the same test that we have for keywords.py.  Please review.

--
assignee:  - yselivanov
keywords: +patch
nosy: +yselivanov
stage:  - patch review
versions: +Python 3.6
Added file: http://bugs.python.org/file39519/test_symbol.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24297] Lib/symbol.py is out of sync with Grammar/Grammar

[Brett Cannon]

Changes by Brett Cannon br...@python.org:


--
priority: normal - release blocker

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24297
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com