Yury Selivanov added the comment:
Martin, it's now updated.
(As for why it wasn't applied in the first place, I guess standard MacOS
`patch` command fails to apply git binary diffs)
--
___
Python tracker rep...@bugs.python.org
Roundup Robot added the comment:
New changeset e9c34e16f445 by Yury Selivanov in branch '3.5':
Issue #24439: Update tulip_coro.dia
https://hg.python.org/cpython/rev/e9c34e16f445
New changeset 15b8a62da6ff by Yury Selivanov in branch 'default':
Merge 3.5 (Issue #24439)
Martin Panter added the comment:
Thanks for reviewing this Yury. Here is a new patch:
* Drop the “native” term; distinguish by referring to “async def” where
necessary
* Add generator version of display_date() coroutine example
* Change chained coroutine example over to “async def” and updated
Changes by Martin Panter vadmium...@gmail.com:
Added file: http://bugs.python.org/file39799/tulip_coro.png
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24439
___
Martin Panter added the comment:
Hi Yury. It looks like you missed my updated /Doc/library/tulip_coro.dia file.
Here it is separately, in case you are having trouble extracting it from the
patch.
--
Added file: http://bugs.python.org/file39810/tulip_coro.dia
Roundup Robot added the comment:
New changeset e31aad001fdb by Yury Selivanov in branch '3.5':
Issue #24439: Improve PEP 492 related docs.
https://hg.python.org/cpython/rev/e31aad001fdb
New changeset d99770da3b2a by Yury Selivanov in branch 'default':
Merge 3.5 (issue #24439)
Yury Selivanov added the comment:
Committed. Thanks a lot, Martin!
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24439
Martin Panter added the comment:
Here is a patch with more improvements to the coroutine documentation,
including:
* Remove expansion of “coroutine” glossary to include generators; it was not my
original intention of this bug. Perhaps this can be dealt with separately in
Issue 24087 if other
Yury Selivanov added the comment:
Hi Martin,
I've left you some feedback in the code review.
* “async def” routines are allowed in addition to generators in asyncio (e.g.
in Task constructor)
Right. I think we need to add some code samples too.
* Other awaitables are also accepted as
Martin Panter added the comment:
When I update my patch I can try updating the asyncio section. However I have
only had limited experience with asyncio, so feel free to suggest things to
add. Here is a list of things I think may need changing:
* “async def” routines are allowed in addition to
Yury Selivanov added the comment:
Martin, if you want to help with the documentation, it would be great if you
can help me with updating asyncio coroutines section:
https://docs.python.org/3.5/library/asyncio-task.html#coroutines
--
___
Python
Yury Selivanov added the comment:
Martin, thanks a lot for the feedback and patch! I'll review the patch when
issue24400 lands.
--
assignee: docs@python - yselivanov
nosy: +ncoghlan
___
Python tracker rep...@bugs.python.org
Martin Panter added the comment:
It seems that Issue 24400 may implement __await__() for native coroutine
instances, making points 1, 2 and 4 mainly redundant. This would also bypass a
fifth problem: the need for the mandatory yet largely useless send(None)
argument.
I am posting
New submission from Martin Panter:
Today I tried playing with the new “async def” functionality in the interactive
interpreter, based on reading the documentation. Here are some bits that
surprised me, so could be the focus of further documentation. (Initial
documentation added in Issue
14 matches
Mail list logo
