Eric Snow added the comment:
What is the level of impact of the callback problem? Of the 4 scenarios in
[1], it seems to me like #1 (C callbacks w/o a module reference) would be the
most common. However, can't that be addressed by adjusting the API, so it
would only be a big problem in the
Eric Snow added the comment:
Sorry I didn't get a review in before. Since subinterpreters and multi-phase
initialization are on my mind, I have a couple questions:
Should there be a note in the Single-phase initialization section (perhaps at
the top of the section) that encourages use of
Petr Viktorin added the comment:
Verifying modules to work ith subinterpreters is tricky. What level of
assurance do you want?
Subinterpreters themselves require that you embed Python, which doesn't lend
itself to an easy example. I hope 2.6 makes the situation better.
Example code is in
Petr Viktorin added the comment:
Thanks for the review.
I've added the explanation you suggested, and I've made the names monospace (or
linked them, where it seemed appropriate). I've also marked *NULL*s like in the
rest of the doc.
--
Added file:
Petr Viktorin added the comment:
Yes!
Aside from the callback problem, which is left for another PEP, but limits PEP
489 usefulness in the real world :(
It turns out that one is quite a rabbit hole. I'll post my findings on that
soon-ish.
--
___
Roundup Robot added the comment:
New changeset bad92d696866 by Nick Coghlan in branch '3.5':
Close #24458: PEP 489 documentation
https://hg.python.org/cpython/rev/bad92d696866
New changeset 86daa37c1cc9 by Nick Coghlan in branch 'default':
Merge fix for #24458 from 3.5
Nick Coghlan added the comment:
Thanks and, as you can see, merged :)
Am I correct in thinking these docs were the only item remaining for PEP 489?
--
resolution: fixed -
stage: resolved -
status: closed - open
___
Python tracker
Nick Coghlan added the comment:
Leaving the tutorial alone until the callback problem is resolved makes sense
to me.
The patch overall looks good, I sent a few more detailed comments via Rietveld.
--
___
Python tracker rep...@bugs.python.org
New submission from Petr Viktorin:
Hello,
Here is a patch documenting PEP 489.
I don't feel comfortable rewriting the tutorial [0] yet: before the issue with
callbacks/module state [1] is solved, which is 3.6 material, multi-phase init
is not suitable for all modules.
So everything in PEP 489
