Roundup Robot added the comment:
New changeset 5400e21e92a7 by Meador Inge in branch '3.5':
Issue #24485: Function source inspection fails on closures.
https://hg.python.org/cpython/rev/5400e21e92a7
New changeset 0e7d64595223 by Meador Inge in branch 'default':
Issue #24485: Function source
Meador Inge added the comment:
Thanks Yury! I have committed my patches to 3.5 and default.
--
resolution: - fixed
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
Yury Selivanov added the comment:
Meador, I've reverted changes introduced in #21217 -- I don't want to risk
shipping 3.5beta4 with broken backwards compatibility.
Feel free to rebase commit your patch (I decorated test_decorator_with_lambda
with @unittest.expectedFailure).
--
Roundup Robot added the comment:
New changeset 4e42a62d5648 by Yury Selivanov in branch '3.5':
Issue #24485: Revert backwards compatibility breaking changes of #21217.
https://hg.python.org/cpython/rev/4e42a62d5648
New changeset 98a2bbf2cce2 by Yury Selivanov in branch 'default':
Merge 3.5
Yury Selivanov added the comment:
Meador, the patch looks OK. Could you please commit it yourself?
--
assignee: - meador.inge
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
Meador Inge added the comment:
Will do. Thanks for the review.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
___
Python-bugs-list
Changes by Larry Hastings la...@hastings.org:
--
priority: release blocker - normal
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
___
Meador Inge added the comment:
Here is a first cut patch that moves things back to using a syntax-level
analysis instead of a bytecode-level one. I extended `BlockFinder`
to skip decorators.
--
keywords: +patch
nosy: +meador.inge
stage: test needed - patch review
Added file:
Terry J. Reedy added the comment:
The test suite must lack, and therefore needs, a simple testcase as in test.py.
In 3.4 and 3.5, getsource() joins the list of lines returned by
getsourcelines(). In both versions, getsourcelines uses findsource(), which
seems to be unchanged. In 3.5, the
Terry J. Reedy added the comment:
I verified (Win7, but should be irrelevant) that test.py works on 2.7.10 and
3.4.3. The failure in 3.5.0b2 is omitting the body of inner. Add another line
to inner and both are omitted, so 'body' seems correct Add another line to
outer, and nothing is
Yury Selivanov added the comment:
Thanks, Terry. I posted some findings to #21217.
--
nosy: +ncoghlan, pitrou
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
Yury Selivanov added the comment:
Looks like this is a regression in 3.5.
--
priority: normal - release blocker
stage: - needs patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
Changes by Yury Selivanov yseliva...@gmail.com:
--
nosy: +yselivanov
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
___
Python-bugs-list
New submission from Malthe Borch:
Very simple to reproduce (see attachment).
--
components: Library (Lib)
files: test.py
messages: 245621
nosy: malthe
priority: normal
severity: normal
status: open
title: Function source inspection fails on closures
type: behavior
versions: Python 3.5,
Changes by bkcsfi sfi bkc...@gmail.com:
--
nosy: +bkcsfi sfi
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24485
___
___
Python-bugs-list mailing
15 matches
Mail list logo
