[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9f4b066754c3 by Antoine Pitrou in branch '2.7': Issue #24489: ensure a previously set C errno doesn't disturb cmath.polar(). https://hg.python.org/cpython/rev/9f4b066754c3 -- ___ Python tracker

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread STINNER Victor
STINNER Victor added the comment: On Python 3.5 and 3.6, You can use math.inf and math.nan. The patch is for 3.4. Ok, it confirms my guess. But when you merge your change into 3.5, you may replace nan and inf with math.nan and math.inf. As you want. --

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread STINNER Victor
STINNER Victor added the comment: polar_errno.patch doesn't apply cleanly on the default branch, I get that you wrote your patch for Python 3.4. +@cpython_only +def test_polar_errno(self): +# Check a previously set C errno doesn't disturb polar() Please add the number of this

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread Roundup Robot
Roundup Robot added the comment: New changeset 70e3230c2872 by Antoine Pitrou in branch '3.4': Issue #24489: ensure a previously set C errno doesn't disturb cmath.polar(). https://hg.python.org/cpython/rev/70e3230c2872 New changeset d165712b2dee by Antoine Pitrou in branch '3.5': Issue #24489:

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: On Python 3.5 and 3.6, You can use math.inf and math.nan. The patch is for 3.4. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24489 ___

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, pushed it! -- resolution: - fixed stage: patch review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24489 ___

[issue24489] cmath.polar() can raise due to pre-existing errno

2015-06-23 Thread Antoine Pitrou
New submission from Antoine Pitrou: Here is a patch, with additional tests. -- components: Library (Lib) files: polar_errno.patch keywords: patch messages: 245678 nosy: mark.dickinson, pitrou priority: normal severity: normal stage: patch review status: open title: cmath.polar() can