Serhiy Storchaka added the comment:
Both variants LGTM. But set_self_contained.diff seems better.
I suppose this is 3.6 only.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - not a bug
stage: patch review - resolved
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
Roundup Robot added the comment:
New changeset 3f2c12c0abdb by Raymond Hettinger in branch 'default':
Issue #24583: Consolidate previous set object updates into a single function
https://hg.python.org/cpython/rev/3f2c12c0abdb
--
___
Python tracker
Serhiy Storchaka added the comment:
5c3812412b6f caused a refleak.
$ ./python -m test.regrtest -uall -R 3:3 test_set
[1/1] test_set
beginning 6 repetitions
123456
..
test_set leaked [23561, 24961, 23961] references, sum=72483
test_set leaked [785, 787, 787] memory blocks, sum=2359
1 test
Roundup Robot added the comment:
New changeset acb5b177dd4e by Raymond Hettinger in branch 'default':
Issue #24583: Fix refcount leak.
https://hg.python.org/cpython/rev/acb5b177dd4e
--
___
Python tracker rep...@bugs.python.org
Raymond Hettinger added the comment:
Added a patch to neaten it up a bit by naming the exit conditions and avoiding
the unnecessary extra incref/decref pair around the resize call.
--
Added file: http://bugs.python.org/file39956/set_named_exits.diff
Serhiy Storchaka added the comment:
AFAIK 3.5+ (not tested).
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
___
Python-bugs-list
Raymond Hettinger added the comment:
Added a variant patch that brings the steps together in a more logical manner
(single entry point at the top and the named exits at the bottom, brings
refcount adjustment logic together in a more coherent way). The restart
target is done the same way as
Raymond Hettinger added the comment:
3.6 only. Correct?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
___
Python-bugs-list mailing
Roundup Robot added the comment:
New changeset 5c3812412b6f by Raymond Hettinger in branch '3.5':
Issue #24583: Fix crash when set is mutated while being updated.
https://hg.python.org/cpython/rev/5c3812412b6f
New changeset 05cb67dab161 by Raymond Hettinger in branch 'default':
Issue #24583:
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
Serhiy Storchaka added the comment:
intermediary.diff LGTM.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
___
Python-bugs-list
Serhiy Storchaka added the comment:
Perhaps the incref/decref pair ought to be moved into
PyObject_RichCompareBool().
This wouldn't help because key can be used after PyObject_RichCompareBool().
--
___
Python tracker rep...@bugs.python.org
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
Added file: http://bugs.python.org/file39890/intermediary.diff
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
___
Changes by STINNER Victor victor.stin...@gmail.com:
--
title: Crash when source set is changed during merging - set.update(): Crash
when source set is changed during merging
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
Serhiy Storchaka added the comment:
The same test is crashed in 3.6 even with index_to_entry.diff.
./python -m test.regrtest -F -m test_merge_and_mutate test_set
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24583
16 matches
Mail list logo
