[issue24678] raiseExceptions typo fix in logging tests
Serhiy Storchaka added the comment: I would use test.support.swapattr(). -- nosy: +serhiy.storchaka ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24678] raiseExceptions typo fix in logging tests
New submission from Jacek Kołodziej: The typo in test_logging was discovered while working on #23883: in two tests the addCleanup call reverts the raiseEx*ec*ptions value (instead of raiseExceptions) in logging module and apparently that didn't manifest itself in any way. Patch attached. -- components: Tests files: test_logging_typo.patch keywords: patch messages: 247047 nosy: Unit03, vadmium, vinay.sajip priority: normal severity: normal status: open title: raiseExceptions typo fix in logging tests versions: Python 3.4, Python 3.5, Python 3.6 Added file: http://bugs.python.org/file39966/test_logging_typo.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24678] raiseExceptions typo fix in logging tests
Serhiy Storchaka added the comment: LGTM. -- assignee: - serhiy.storchaka stage: - commit review type: - behavior ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24678] raiseExceptions typo fix in logging tests
Roundup Robot added the comment: New changeset 20e2b980bb87 by Serhiy Storchaka in branch '3.4': Issue #24678: Fixed raiseExceptions typo in logging tests. https://hg.python.org/cpython/rev/20e2b980bb87 New changeset 7a54e400155f by Serhiy Storchaka in branch '3.5': Issue #24678: Fixed raiseExceptions typo in logging tests. https://hg.python.org/cpython/rev/7a54e400155f New changeset 83b45ea19d00 by Serhiy Storchaka in branch 'default': Issue #24678: Fixed raiseExceptions typo in logging tests. https://hg.python.org/cpython/rev/83b45ea19d00 -- nosy: +python-dev ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24678] raiseExceptions typo fix in logging tests
Serhiy Storchaka added the comment: Thank you for your contribution Jacek. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com
[issue24678] raiseExceptions typo fix in logging tests
Jacek Kołodziej added the comment: s/swapattr/swap_attr/g :) Done. -- Added file: http://bugs.python.org/file39968/test_logging_typo.v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24678 ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com