Changes by Arfrever Frehtes Taifersar Arahesis arfrever@gmail.com:
--
nosy: +Arfrever
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
Raymond Hettinger added the comment:
Test case?
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
___
Python-bugs-list mailing list
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
resolution: - fixed
status: open - closed
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
Changes by Raymond Hettinger raymond.hettin...@gmail.com:
--
assignee: - rhettinger
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
___
STINNER Victor added the comment:
Can someone please write an unit test to avoid regressions in the future?
--
nosy: +haypo
resolution: fixed -
status: closed - open
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
Roundup Robot added the comment:
New changeset fd3fb122c5ff by Raymond Hettinger in branch '3.4':
Issue #24735: Fix invalid memory access in combinations_with_replacement()
https://hg.python.org/cpython/rev/fd3fb122c5ff
--
nosy: +python-dev
___
Changes by Berker Peksag berker.pek...@gmail.com:
--
stage: patch review - resolved
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
___
Stefan Krah added the comment:
Victor, there was no actual crash, just a potential one. In
terms of the observable runtime behavior the code behaved
correctly.
I would not know what to test for, unless we set up a buildbot
running Valgrind (which is impracticable for a number of reasons).
STINNER Victor added the comment:
Oh I see. Ok, since it's a corner case, I'm fine with no unit test. Thanks for
the report Stefan, and thanks for the fix Raymond ;-)
--
resolution: - fixed
status: open - closed
___
Python tracker
New submission from Stefan Krah:
There's a corner case in cwr_next(), where the pool size is zero
but pool[0] is accessed:
from itertools import *
it = combinations_with_replacement([], 0)
next(it)
Patch attached.
--
components: Extension Modules
files: itertools_invalid_access.diff
Changes by Serhiy Storchaka storch...@gmail.com:
--
nosy: +serhiy.storchaka
stage: - patch review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24735
___
11 matches
Mail list logo