[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Change by Terry J. Reedy : -- components: +IDLE ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Changes by Terry J. Reedy : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Roundup Robot added the comment: New changeset 76f831e4b806 by Terry Jan Reedy in branch 'default': Issue #24759: IDLE requires tk 8.5 and availability ttk widgets. https://hg.python.org/cpython/rev/76f831e4b806 -- ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Roundup Robot added the comment: New changeset 81927f86fa3a by Terry Jan Reedy in branch 'default': Issue #24759: Add test for IDLE syntax colorizoer. https://hg.python.org/cpython/rev/81927f86fa3a -- ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: Fixed whitespace and added comment. -- Added file: http://bugs.python.org/file43254/require85-v3.diff ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: I believe require85-v2.diff adds everything specified in my last post. -- Added file: http://bugs.python.org/file43210/require85-v2.diff ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Roundup Robot added the comment: New changeset e6560f018845 by Terry Jan Reedy in branch '2.7': Issue #24759: Add 'private' notice for idlelib.idle_test. https://hg.python.org/cpython/rev/e6560f018845 New changeset d75a25b3abe1 by Terry Jan Reedy in branch '3.5': Issue #24759: Add 'private'

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: I saw the review comment about adding lines. I do not have 8.4 either, but I get the point: the startup version check does not not guard the unittests. After test.text_idle imports unittest and tkinter (as tk) (line 6), I will add if tk.TkVersion < 8.5:

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Serhiy Storchaka added the comment: I meant Tk 8.4, not Python 3.4. Tests should be either passed or skipped, no errors raised. -- ___ Python tracker

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: No, 3.4 is security fixes only and this is a 3.6 only issue. -- ___ Python tracker ___

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Serhiy Storchaka added the comment: Did you try to run tests with Tk 8.4? -- ___ Python tracker ___ ___

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: Trying again. And yes, I would like a review. I don't think there is anything system specific, but some deletions required a minor rewrite. -- keywords: +patch Added file: http://bugs.python.org/file43149/require85.diff

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Serhiy Storchaka added the comment: Do you forgot to attach a patch? -- ___ Python tracker ___ ___

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: Given what Serhiy said, the core of this patch is the original patch with a test of TkVersion instead of importing ttk. Code that only ran for 8.4- is removed. Some minimal new tests are added, and I may add some more. None of the changes should depend on

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Serhiy Storchaka added the comment: My patch in issue24750 makes sense only if we want support Tcl/Tk 8.4. I think that if require Tcl/Tk 8.5+, we can use Ttk directly and unconditionally. I don't think that it can be not working. -- ___ Python

[issue24759] Idle: require tk 8.5 and ttk widgets, and drop unneeded code.

Terry J. Reedy added the comment: In msg265349, Ned stated that running IDLE with 8.4 should no longer be a requirement in 3.6. Hence the revised title and restriction to 3.6. Serhiy, I read the code in your #24750 patch. Should it not be enough to first check tkinter.Tkversion >= 8.5