[issue24760] IDLE settings dialog shouldn't be modal

[Terry J. Reedy]

Change by Terry J. Reedy :


--
versions: +Python 3.10 -Python 3.6, Python 3.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Terry J. Reedy]

Changes by Terry J. Reedy :


--
assignee:  -> terry.reedy
versions: +Python 3.7 -Python 2.7, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

Mark Roseman added the comment:

Terry, when you get a chance, it would be great if you could have a look at 
demodalize.patch (or if you can suggest someone else who would be good to take 
a peek at it).

This is sort of the baseline for the uifactory, and touches a lot of things in 
small ways to decouple some of the inter-module dependencies. 

Other things (the new query dialogs, ttk versions of configuration and search 
dialogs, etc.) depend on this patch to wire the uifactory into the 
infrastructure.

Thanks!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

Mark Roseman added the comment:

The attached demodalize.patch (which includes the changes from the previously 
posted decouple_config.patch) changes both the settings dialog and the about 
dialog to be non-modal.

There's a new class UIFactory which is responsible for launching these kinds of 
windows, keeping track of them, and making sure there's only one of each kind 
at a time. This is also where the logic for choosing ttk vs. non-ttk components 
will go.

As a (questionable) bonus, the about dialog, which now incorporates the 
README's etc directly into the window rather than launching further modal 
dialogs, also has some other minor cosmetic changes.

--
versions:  -Python 3.4
Added file: http://bugs.python.org/file40163/demodalize.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

Mark Roseman added the comment:

I've attached decouple_config.patch, which removes some internal knowledge 
about EditorWindow from configDialog. This is a step towards making the 
preferences dialog non-modal (and also to launching either the current dialog, 
or a new ttk-dependent one).

The thing that could currently break things if we switched to non-modal is that 
when configuration changes, we directly examine parent.instance_dict. 
Unfortunately, it's possible that parent will have been destroyed before this 
happens.

Instead of holding onto parent, the patch holds onto the FileList object, which 
should persist. It also takes the opportunity to delegate the specifics of what 
should happen to active editor windows on config changes (previously in 
configDialog) to FileList, which in turn delegates the specifics back to each 
EditorWindow instance.

A separate patch, depending on this refactoring, will then change the dialog so 
that it can be launched non-modally, and make sure only a single instance is 
present.

--
keywords: +patch
Added file: http://bugs.python.org/file40159/decouple_config.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

Mark Roseman added the comment:

Incidentally (and this I would say is a definite bug) because the modal doesn't 
fully work on the Mac, you can actually create multiple copies of the config 
dialog!

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Terry J. Reedy]

Terry J. Reedy added the comment:

I don't know. I do not thing that any option settings affect the dialog box 
itself, Someone could switch modal off and experiment.  It would certainly make 
it easier to change something, Apply, and then try it out.  The is one place I 
would not feel obligated to follow modal-happy Microsoft.  (Too small, cramped 
dialog boxes designed for 400x600 screen is another.)

I have asked the same on at least one of the search dialog issues.  The search 
dialog for Notepad++ is not modal and works fine.

Also see #24039.

--
stage:  - needs patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

New submission from Mark Roseman:

Is there any reason the IDLE settings dialog is modal?

(Actually while it is modal on Windows and Linux, on OS X you can actually 
switch back to the main window while the settings dialog is up, but you can't 
actually type etc. into it!)

While I could probably ask the same question about all the other modal dialogs, 
let's start here. :-)

--
components: IDLE
messages: 247707
nosy: markroseman, terry.reedy
priority: normal
severity: normal
status: open
title: IDLE settings dialog shouldn't be modal
type: enhancement
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24760] IDLE settings dialog shouldn't be modal

[Mark Roseman]

Mark Roseman added the comment:

Ok, I'll do some playing around with that one over the next few days, and see 
if anything comes up.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24760
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com