[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Thanks, that was it.  I actually want to not use the scroll bar unless needed 
for an extension with more than 15 or so settings, but that is another patch.  
Ditto for the list of extensions.  This looks OK for now.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Roundup Robot]

Roundup Robot added the comment:

New changeset a96e39e20490 by Terry Jan Reedy in branch '2.7':
Issue #24782: Limit width of canvas and hence IDLE settings dialog.
https://hg.python.org/cpython/rev/a96e39e20490

New changeset 0847398f9b00 by Terry Jan Reedy in branch '3.4':
Issue #24782: Limit width of canvas and hence IDLE settings dialog.
https://hg.python.org/cpython/rev/0847398f9b00

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

The extra width appears to be coming from the canvas inside 
VerticalScrolledFrame; the canvas gets the default size and the frame adjusts 
to fit its contents (the canvas and the scrollbar). If you really want to 
reduce the size, add a "-width" option where that canvas is being created.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

There are two 'width=250' settings, which I tried changing to 150, with no 
effect, so there is something else making the dialog wider than before.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Roundup Robot]

Roundup Robot added the comment:

New changeset 8953a42c2ac4 by Terry Jan Reedy in branch '2.7':
Issue #24782: Don't try to run now-removed extension dialog test.
https://hg.python.org/cpython/rev/8953a42c2ac4

New changeset 4bf862fc10a5 by Terry Jan Reedy in branch '3.4':
Issue #24782: Don't try to run now-removed extension dialog test.
https://hg.python.org/cpython/rev/4bf862fc10a5

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

There is one issue.  The window is wider now, I suspect because of the 
extension frame, which is wider than it need to be, at least for now.  I will 
try adjusting it.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Nice. The only changes I had to make other than a doc change are 'Settings tab' 
to 'Extensions tab' and deletion of an line-ending space that got added in 
editing the extension doc string.  We both need to remember to strip trailing 
whitespace, as it causes changesets to be rejected when pushed. Pl

--
assignee:  -> terry.reedy
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Roundup Robot]

Roundup Robot added the comment:

New changeset 334dc1abc8af by Terry Jan Reedy in branch '2.7':
Issue #24782: Finish converting the Configure Extension dialog into a new
https://hg.python.org/cpython/rev/334dc1abc8af

New changeset 5647c61fb593 by Terry Jan Reedy in branch '3.4':
Issue #24782: Finish converting the Configure Extension dialog into a new
https://hg.python.org/cpython/rev/5647c61fb593

New changeset 6bce28fec911 by Terry Jan Reedy in branch '2.7':
Issue #24782: whitespace
https://hg.python.org/cpython/rev/6bce28fec911

New changeset 4ed0cc2b7c7c by Terry Jan Reedy in branch '3.4':
Issue #24782: whitespace
https://hg.python.org/cpython/rev/4ed0cc2b7c7c

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

No, I don't, sorry.  If it will be quick for you to do, no problem, otherwise 
I'd be happy to put it together.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Go ahead then.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

Patch against head to change extensions dialog to a pane of main config dialog.

--
Added file: http://bugs.python.org/file40761/mergeext.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

Same patch against 2.7

--
Added file: http://bugs.python.org/file40762/mergeext27.cfg

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Do you have a patch to move the untabbed pane, as is, to preferences?  If not, 
I will write one.

--
versions: +Python 3.4 -Python 3.2

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Roundup Robot]

Roundup Robot added the comment:

New changeset 919cee158a89 by Terry Jan Reedy in branch '2.7':
Issue #24782: In Idle extension config dialog, replace tabs with sorted list.
https://hg.python.org/cpython/rev/919cee158a89

New changeset ce13593e378c by Terry Jan Reedy in branch '3.4':
Issue #24782: In Idle extension config dialog, replace tabs with sorted list.
https://hg.python.org/cpython/rev/ce13593e378c

--
nosy: +python-dev

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

Yes that should be good to go

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

Do you consider the second patch ready as is (as a step toward doing the 
merge)?  Is so, I will do a commit review.

--
stage:  - patch review

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

I presume sorting the list is a trivial matter.

--

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

Yup. Revised extdlg-sorted.patch attached.  Thanks for noticing that!

--
Added file: http://bugs.python.org/file40131/extdlg-sorted.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

Screenshot extdlg.png shows result

--
Added file: http://bugs.python.org/file40119/extdlg.png

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

Mark Roseman added the comment:

I've attached extdlg.patch, which changes the UI for the configure extensions 
dialog. 

In particular, it replaces the stacked tabs with a listbox on the left, with 
the details of each extension appearing in a labelframe on the right. The 
inside of the labelframe gets swapped in with pretty much the same thing that 
was in the dialog before.

This should be compatible with Tk 8.4, as ttk was not used.

--
keywords: +patch
Added file: http://bugs.python.org/file40118/extdlg.patch

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Mark Roseman]

New submission from Mark Roseman:

I'm wondering about moving the functionality of the 'configure extensions' 
dialog into the main configuration dialog.  As I don't know the history here, 
I'm wondering why it was made separate.

My proposal would be to add an 'Extensions' tab in the main config dialog. 
Along the left would be a listbox holding the names of each extension. Along 
the right would be options for the extension selected in the listbox (done 
pretty much the same as now). Selecting a different extension from the list 
would swap in the appropriate set of options.

This would have the additional advantage of doing away with the stacked tabs.

--
components: IDLE
messages: 247898
nosy: kbk, markroseman, roger.serwy, terry.reedy
priority: normal
severity: normal
status: open
title: Merge 'configure extensions' into main IDLE config dialog
type: enhancement
versions: Python 3.5, Python 3.6

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24782] Merge 'configure extensions' into main IDLE config dialog

[Terry J. Reedy]

Terry J. Reedy added the comment:

In general, Idle-sig is a better place to ask question ;-).  I applied the 
extension dialog patch just a year ago (#3068), It still needs improvements 
(#22704, #22705, #22706, #22707 #22726). Before that, people had to hand-edit 
either the idlelib or user version. So I applied the patch when clearly usable, 
and did not worry about making it 'perfect' first. 

Part of the answer to why separate dialogs is related to there being a) a 
separate config file (but the other dialog handles the other three) and 
probably more importantly, b) the set of extension being extensible, both by us 
and by users.

This all said, I dislike the jumbled stacked tabs. Also, the entry space is 
wider than needed for any of our extensions. So whether the dialogs are 
consolidated or not, I like the idea of three columns: alphabetical list of 
extensions (all visible unless a user adds a large number), option names, and 
value entry. I would like to see a patch for this first.  I would not mind 
patches for some of the issue above right after. I would like to improve this 
box before using ttk.

The Idle dialog has room for an Extensions tab without stacking.  I would like 
to see a separate, later patch for consolidation.

--
nosy: +taleinat
versions: +Python 2.7, Python 3.2

___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue24782
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com