[issue24932] Use proper command line parsing in _testembed

2019-05-18 Thread Eric Snow 


Change by Eric Snow :


--
nosy: +vstinner

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-05-09 Thread Nick Coghlan 

Nick Coghlan added the comment:

Based on the latest round of PEP 538 review, the related test case that 
currently relies on _testembed is going to be able to be simplified to just 
setting LC_ALL=C when calling the subprocess (the amount of code it's letting 
me delete from the draft patch is further persuading me that changing the env 
var updates from "LC_ALL & LANG" to "LC_CTYPE & LANG" is the right call).

That means that change will also eliminate the dependence on this test suite 
enhancement for backports.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-05-05 Thread Charalampos Stratakis 

Charalampos Stratakis added the comment:

Downstream backporting of PEP 538 to the 3.6 branch also depends on this fix.

Would it be beneficial in any way to cherry-pick it for 3.6?

--
nosy: +cstratak

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-03-31 Thread Donald Stufft 

Changes by Donald Stufft :


--
pull_requests: +965

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-01-01 Thread Steve Dower 

Steve Dower added the comment:

Buildbots are happy, so I'm calling this done. Jumping straight to getopt is 
overengineering right now in my opinion, but if there's a need for it with a 
future test we can consider it then.

--
resolution:  -> fixed
stage: commit review -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-01-01 Thread Steve Dower 

Steve Dower added the comment:

Patch committed without modification. I'll keep an eye on the buildbots just in 
case, though I may end up going offline before they get to this changeset.

--
assignee:  -> steve.dower
stage:  -> commit review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2017-01-01 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset 69b2a6284f3d by Steve Dower in branch 'default':
Issue #24932: Use proper command line parsing in _testembed
https://hg.python.org/cpython/rev/69b2a6284f3d

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2016-12-30 Thread Nick Coghlan 

Nick Coghlan added the comment:

Steve's patch LGTM, and I now agree our needs are simple enough that we can 
rely on subprocess+unittest for the result reporting.

I'd just missed Steve's simple solution of using the return code to indicate 
success or failure, as well as Eric's approach in issue 29102 of teaching the 
related Python test case to read the text output from the _testembed test case.

If we eventually want to go beyond the single "run this test case" argument, 
then adding getopt() support to _testembed should be sufficient.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue24932] Use proper command line parsing in _testembed

2016-12-30 Thread Nick Coghlan 

Changes by Nick Coghlan :


--
title: Migrate _testembed to a C unit testing library -> Use proper command 
line parsing in _testembed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com