[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Change by Dong-hee Na : -- versions: +Python 3.11 -Python 2.7, Python 3.5, Python 3.6 ___ Python tracker ___ ___ Python-bugs-list

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Hugo Delgado added the comment: Yes, I've created a PR for it. https://github.com/python/cpython/pull/27751 Happy to adapt it as needed. Thanks -- ___ Python tracker ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Change by Hugo Delgado : -- pull_requests: +26228 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/27751 ___ Python tracker ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Andrei Kulakov added the comment: Also see https://bugs.python.org/issue42255 Hugo: can you convert the patch to a PR? -- nosy: +andrei.avk ___ Python tracker ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

hudelgado added the comment: I took a look at it and have a some more questions. The class MacOSX(BaseBrowser) seems to be broken because it uses 'OpenUrl' which doesn't work in most recent versions of applescript, also that class doesn't seem to be used anywhere, is it ok to remove it, or

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Senthil Kumaran added the comment: Hugo, I'd welcome such a change. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

hudelgado added the comment: Ok, I'm thinking in also replace the os.popen calls with subprocess.Popen to keep consistency with existing tests. Do you think it's a good approach? Or should be better to just add some tests around the current implementation? --

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Senthil Kumaran added the comment: Hugo, please go ahead and a test for this patch. -- assignee: -> orsenthil ___ Python tracker ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Hugo Delgado added the comment: I've bumped into this and won't mind working on it, is it ok for me to try to finish it? -- nosy: +Hugo Delgado ___ Python tracker ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Change by Eitan Adler : -- nosy: +eitan.adler ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Changes by Eric Huss : -- nosy: +ehuss ___ Python tracker ___ ___ Python-bugs-list mailing

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Changes by Doug Hellmann : -- nosy: +doughellmann ___ Python tracker ___ ___

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Simon Conseil added the comment: I have looked at the webbrowser tests and it seems not so easy: currently the MacOS browser classes are not tested, and they don't the GenericBrowser base class. Instead they use custom code with os.popen, so it would require some work either replace os.popen

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Senthil Kumaran added the comment: Simon, sure. It is just for someone, either commiters or other interested folks to add the tests on top of your patch. Agree with you that more change is required to add the required tests. -- ___ Python tracker

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Senthil Kumaran added the comment: The patch is correct and will fix the issue. It will require test coverage to be complete so that we don't land upon similar issues in future. -- nosy: +orsenthil stage: -> test needed versions: +Python 3.5, Python 3.6 -Python 3.4

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

Erwann Mest added the comment: +1 I've got like 3 apps which are broken. - https://github.com/mkdocs/mkdocs/issues/465 - https://bugzilla.mozilla.org/show_bug.cgi?id=1012443 -- nosy: +_kud ___ Python tracker

[issue24955] webbrowser broken on Mac OS X when using the BROWSER variable

New submission from Simon Conseil: Hi, There is an issue in the webbrowser module for Mac OS when the BROWSER environment variable is set: Python 2.7.10 (default, Jul 14 2015, 19:46:27) [GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.39)] on darwin Type help, copyright, credits or license