[issue25002] Deprecate asyncore/asynchat

Barry A. Warsaw added the comment: For the archaeologists of the future, smtpd.py is also deprecated in favor of aiosmtpd. http://aiosmtpd.readthedocs.io/en/latest/ -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Sounds good. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker ___

[issue25002] Deprecate asyncore/asynchat

STINNER Victor added the comment: I suggest to close this issue and instead work on the the issue #28533: modify code using asyncore to use something else. -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Changes by Giampaolo Rodola' : -- nosy: +giampaolo.rodola ___ Python tracker ___ ___

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: OK, backed out the code changes, kept the docs. -- ___ Python tracker ___

[issue25002] Deprecate asyncore/asynchat

Roundup Robot added the comment: New changeset 6eb3312a9a16 by Guido van Rossum in branch '3.6': Issue #25002: Back out asyncore/asynchat deprecation. https://hg.python.org/cpython/rev/6eb3312a9a16 New changeset 2879185bc511 by Guido van Rossum in branch 'default': Issue #25002: Back out

[issue25002] Deprecate asyncore/asynchat

Martin Panter added the comment: Perhaps it is okay to keep the documentation changes, but I think either the library changes should be reverted or worked around where the modules are still in use. I normally run the tests with -Werror, and the failures I get are: * test_ssl, test_smtplib,

[issue25002] Deprecate asyncore/asynchat

STINNER Victor added the comment: R. David Murray added the comment: > The alternative has already been written: aiosmtpd, in the aiolibs project. The question is should it be added to the stdlib... I suggest to keep it on PyPI to keep fast releases. --

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Serhiy, so should I revert this patch for now? Or are the silent deprecation warnings outside the test suite okay? (In that case, maybe Mariatta can upload a patch?) -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Changes by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___

[issue25002] Deprecate asyncore/asynchat

R. David Murray added the comment: The alternative has already been written: aiosmtpd, in the aiolibs project. The question is should it be added to the stdlib... -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Mariatta Wijaya added the comment: Thanks Serhiy, I created these two tickets: https://bugs.python.org/issue28534 https://bugs.python.org/issue28533 -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Serhiy Storchaka added the comment: Ah, asyncore/asynchat are used in smtpd! It looks to me that we should first write asyncio alternative to smtpd, then deprecate smtpd, and only after this we can deprecate asyncore/asynchat. -- dependencies: +Deprecate smtpd (based on deprecated

[issue25002] Deprecate asyncore/asynchat

Serhiy Storchaka added the comment: > Should I create a different ticket about replacing asyncore and asynchat? This may require several tickets, one per case. -- components: +Library (Lib) resolution: fixed -> stage: -> needs patch type: -> enhancement versions: +Python 3.7

[issue25002] Deprecate asyncore/asynchat

Mariatta Wijaya added the comment: Sorry about this Serhiy. I can work on another patch based on your code snippet later today. Should I create a different ticket about replacing asyncore and asynchat? -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Serhiy Storchaka added the comment: I think replacing import asynchat import asyncore with with warnings.catch_warnings(): warnings.simplefilter('ignore', PendingDeprecationWarning) import asynchat import asyncore can help. asynchat and asyncore are used

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Sorry about that. Should I roll it back or is there a way to make the test pass (expect this deprecation)? -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Changes by Serhiy Storchaka : -- status: closed -> open ___ Python tracker ___

[issue25002] Deprecate asyncore/asynchat

Serhiy Storchaka added the comment: This change broke buildbots. $ ./python -We -m test.regrtest test_os Run tests sequentially 0:00:00 [1/1] test_os test test_os crashed -- Traceback (most recent call last): File "/home/serhiy/py/cpython/Lib/test/libregrtest/runtest.py", line 151, in

[issue25002] Deprecate asyncore/asynchat

Roundup Robot added the comment: New changeset bb23770f82f1 by Guido van Rossum in branch '3.6': Issue 25002: Deprecate asyncore/asynchat. Patch by Mariatta. https://hg.python.org/cpython/rev/bb23770f82f1 New changeset 3b8dfe6f5bcb by Guido van Rossum in branch 'default': Issue 25002: Deprecate

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Applied: remote: notified python-check...@python.org of incoming changeset bb23770f82f1 remote: notified python-check...@python.org of incoming changeset 3b8dfe6f5bcb -- resolution: -> fixed status: open -> closed

[issue25002] Deprecate asyncore/asynchat

Mariatta Wijaya added the comment: Hi, Attached is the patch that adds pending deprecation warnings to asyncore and asynchat. Please review. Thanks :) -- keywords: +patch nosy: +Mariatta Added file: http://bugs.python.org/file45210/issue25002.patch

[issue25002] Deprecate asyncore/asynchat

Mark Lawrence added the comment: IIRC I flagged up oustanding asyncore/asynchat issues months or even years back and Victor closed a lot down, so there shouldn't be many left to deal with. -- nosy: +BreamoreBoy ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

R. David Murray added the comment: Yes, stopping changing asyncore/asynchat also means it becomes a stable target for people who *are* using it for 2/3 code. We may have effectively done this already (without closing the open issues): the last asyncore-specific change (as opposed to

[issue25002] Deprecate asyncore/asynchat

STINNER Victor added the comment: If you care of smooth python 2 => python 3 migration, I suggest to deprecate smtpd and remove it later, when asyncore & asynchat will also be removed (ex: in Python 4?). I suggest to write a *new* SMTP server module using asyncio. As I explained, the API will

[issue25002] Deprecate asyncore/asynchat

Brett Cannon added the comment: Victor's suggestion also aligns with my thinking on the subject as well: deprecate the modules but simply leave them sitting there for compatibility reasons until Python 4 of whenever we feel like the Python 2 transition is done for those that will ever bother

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: > Is it ok to add the PendingDeprecationWarning in Python 3.5.1? I prefer to wait until 3.6. A bugfix release should not rock the boat, it should not make your code emit new warnings. -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

STINNER Victor added the comment: > Ideally these modules should emit a deprecation warning starting in 3.6 Is it ok to add the PendingDeprecationWarning in Python 3.5.1? -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Raymond Hettinger added the comment: In addition to a PendingDeprecationWarning in 3.6, it might be nice to put a note in the asyncore/asynchat docs like we did for optparse. -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Barry A. Warsaw added the comment: On Sep 04, 2015, at 08:55 PM, STINNER Victor wrote: >Maybe it can be fun to rewrite the module using asyncio, but I'm not >convinced that a SMTP server in the Python stdlib is super useful. As I mentioned in issue25008, removing smtpd would be a hardship for

[issue25002] Deprecate asyncore/asynchat

Brett Cannon added the comment: I opened http://bugs.python.org/issue25008 to discuss deprecating smtpd since this issue is about asyncore/asynchat. -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

New submission from Guido van Rossum: Now that we've got asyncio in two releases (3.4 and 3.5) we should start deprecating asyncore and asynchat. There isn't much use of these in the stdlib (smtpd.py uses them, and a bunch of tests) and we should probably rewrite those to use asyncio. Maybe

[issue25002] Deprecate asyncore/asynchat

STINNER Victor added the comment: The documentation of both modules begin with the following note: "This module exists for backwards compatibility only. For new code we recommend using asyncio." What do you mean by deprecating the module? Emit a PendingDeprecationWarning in Python 3.6 and

[issue25002] Deprecate asyncore/asynchat

Donald Stufft added the comment: I'm all for deprecating asyncore/asynchat but should deprecating them wait until asyncio is no longer provisional? -- nosy: +dstufft ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Yes, in 3.6 asyncio will no longer be provisional and we can start deprecating async{ore,hat}. Which is why I marked this bug with 3.6. -- ___ Python tracker

[issue25002] Deprecate asyncore/asynchat

Changes by Guido van Rossum : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list

[issue25002] Deprecate asyncore/asynchat

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue25002] Deprecate asyncore/asynchat

Eric V. Smith added the comment: I use smtpd.py for testing my code. But it's not such a big deal that I couldn't live without it. If I have some time to burn, I might convert it to asyncio so I can continue to use it. -- nosy: +eric.smith ___

[issue25002] Deprecate asyncore/asynchat

Guido van Rossum added the comment: Ideally these modules should emit a deprecation warning starting in 3.6 (when asyncio is no longer provisional) and we should strive to delete them per 3.8. If nobody rewrites smptd.py using asyncio it should be deleted at the same time. --

[issue25002] Deprecate asyncore/asynchat

R. David Murray added the comment: smtpd is used for testing smtplib. It is also used in test_logging. I would object to having it removed, but I suspect we can manage to rewrite it by 3.8. Maybe Eric and I can collaborate on it. -- nosy: +r.david.murray