[issue25114] asynico: add ssl_object extra info

2015-09-21 Thread STINNER Victor 

Changes by STINNER Victor :


--
keywords: +3.5regression

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25114] asynico: add ssl_object extra info

2015-09-21 Thread Yury Selivanov 

Yury Selivanov added the comment:

the patch lgtm

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25114] asynico: add ssl_object extra info

2015-09-21 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset d7859e7e7071 by Victor Stinner in branch '3.4':
Issue #25114, asyncio: add ssl_object extra info to SSL transports
https://hg.python.org/cpython/rev/d7859e7e7071

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25114] asynico: add ssl_object extra info

2015-09-18 Thread STINNER Victor 

STINNER Victor added the comment:

Guido? Yury? Can you please review attached patch? It looks like a Python 3.5 
regression.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25114] asynico: add ssl_object extra info

2015-09-14 Thread STINNER Victor 

New submission from STINNER Victor:

Attached patch adds the "ssl_object" extra information to SSL sockets. For the 
legacy SSL implementation, it's a ssl.SSLSocket instance. For the new SSL 
implementation, it's a ssl.SSLObject instance.

ssl.SSLObject and ssl.SSLSocket have a similar but different API. Both classes 
provide important methods like getpeercert().

This issue fixes a regressions of Python 3.5 compared to Python 3.4 in asyncio 
SSL sockets: it's no more possible to get the peer certificate as a binary 
object (only as text). See the issue #22768.

My patch adds also unit tests on SSL extra info. We only had poor unit tests on 
these info.

--
components: asyncio
files: ssl_object.patch
keywords: patch
messages: 250705
nosy: gvanrossum, haypo, mathieui, yselivanov
priority: normal
severity: normal
status: open
title: asynico: add ssl_object extra info
versions: Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file40468/ssl_object.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25114] asynico: add ssl_object extra info

2015-09-14 Thread STINNER Victor 

STINNER Victor added the comment:

Workaround for Python 3.5.0: force the legacy SSL implementation. For example, 
monkey patch the asyncio module with:

asyncio.sslproto._is_sslproto_availabe=lambda: False

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com