[issue25130] Make tests more PyPy compatible

Łukasz Langa added the comment: New changeset 462c1f0403324efc27c11435da12b8d16f5387de by Serhiy Storchaka in branch '3.10': [3.10] bpo-25130: Add calls of gc.collect() in tests to support PyPy (GH-28005) (GH-28027)

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 330aaee39cbc556be01534b1dbf65d20f04c by Serhiy Storchaka in branch '3.9': [3.9] bpo-25130: Add calls of gc.collect() in tests to support PyPy (GH-28005). (GH-28028)

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26474 pull_request: https://github.com/python/cpython/pull/28028 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26473 pull_request: https://github.com/python/cpython/pull/28027 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 2a8127cafe1d196f858a3ecabf5f1df3eebf9a12 by Serhiy Storchaka in branch 'main': bpo-25130: Add calls of gc.collect() in tests to support PyPy (GH-28005) https://github.com/python/cpython/commit/2a8127cafe1d196f858a3ecabf5f1df3eebf9a12

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset dab74d68e3f8391cb4b404b397ab80e2e0188d1f by Serhiy Storchaka in branch '3.9': [3.9] bpo-25130: Make SQLite tests more compatible with PyPy (GH-28021) (GH-28023)

[issue25130] Make tests more PyPy compatible

miss-islington added the comment: New changeset a49398b643b3a2e6f9cc39729c528eb1e4385b1a by Miss Islington (bot) in branch '3.10': bpo-25130: Make SQLite tests more compatible with PyPy (GH-28021) https://github.com/python/cpython/commit/a49398b643b3a2e6f9cc39729c528eb1e4385b1a --

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26469 pull_request: https://github.com/python/cpython/pull/28023 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Change by miss-islington : -- pull_requests: +26468 pull_request: https://github.com/python/cpython/pull/28022 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 07d3d54f4e84b1259b800884b202701f69e408d8 by Serhiy Storchaka in branch 'main': bpo-25130: Make SQLite tests more compatible with PyPy (GH-28021) https://github.com/python/cpython/commit/07d3d54f4e84b1259b800884b202701f69e408d8 --

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26467 pull_request: https://github.com/python/cpython/pull/28021 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 1046cd06b0e2f20b3be93de83d49b684956af98d by Serhiy Storchaka in branch '3.9': [3.9] bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002) (GH-28017)

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset 779b9aef4fb2750f57ce07f0efbc8ce8406e43ab by Miss Islington (bot) in branch '3.10': bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002) (GH-28016)

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26462 pull_request: https://github.com/python/cpython/pull/28017 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +26461 pull_request: https://github.com/python/cpython/pull/28016 ___ Python tracker

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: New changeset eb263f9a356f5c5f21b8d5ce20bac92f31c40cad by Carl Friedrich Bolz-Tereick in branch 'main': bpo-25130: Make unit-test about restricting the maximum number of nested blocks cpython-only (GH-28002)

[issue25130] Make tests more PyPy compatible

Change by Carl Friedrich Bolz-Tereick : -- nosy: +Carl.Friedrich.Bolz nosy_count: 6.0 -> 7.0 pull_requests: +26460 pull_request: https://github.com/python/cpython/pull/28002 ___ Python tracker

[issue25130] Make tests more PyPy compatible

Change by Serhiy Storchaka : -- pull_requests: +26447 pull_request: https://github.com/python/cpython/pull/28005 ___ Python tracker ___

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: Unfortunately Martin's comments are not available now, after shutting down the Rietveld service. Here is a new PR which contains extraction of PyPy changes related to calling gc.collect() for 3.8. I removed changes which look specific for PyPy and left

[issue25130] Make tests more PyPy compatible

Terry J. Reedy added the comment: With 2.7 EOL, is this still relevant? -- nosy: +terry.reedy ___ Python tracker ___ ___

[issue25130] Make tests more PyPy compatible

Change by Ronan Lamy : -- nosy: +Ronan.Lamy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: Just for reference here is a full difference between 2.7 tests in PyPy and CPython. It makes tests fail in CPython and skips some tests or makes them too lenient. -- Added file: http://bugs.python.org/file40481/pypy_tests-2.7_full.patch

[issue25130] Make tests more PyPy compatible

Maciej Fijalkowski added the comment: Hi I can answer precise questions, which tests are you asking about? Note that if the point is to unify the test suite, would be cool to make changes to both pypy and cpython and not just change cpython one. --

[issue25130] Make tests more PyPy compatible

Maciej Fijalkowski added the comment: Hi Looking through your comments, yes, maybe those tests or those things require fixing. We at pypy don't have enough will to fight python-dev most of the time, so the usual approach is to do "minimal hack that works" without trying to dwelve into why

[issue25130] Make tests more PyPy compatible

Martin Panter added the comment: Maciej: I put a few questions and comments in the code review. See the (also linked next to Serhiy’s first patch). -- ___ Python tracker

[issue25130] Make tests more PyPy compatible

Serhiy Storchaka added the comment: Thank you for your comments Martin. I need a time to think over them and provide alternative solutions that less depend on garbage collecting. May be Maciej can answer questions about causes of some PyPy changes. --

[issue25130] Make tests more PyPy compatible

Martin Panter added the comment: Left some comments. There are a few test cases that I suspect are relying on side effects of garbage collection to perform some other test, and it would be better to rework the test. In the other cases, I agree that actual garbage collection behaviour is being

[issue25130] Make tests more PyPy compatible

New submission from Serhiy Storchaka: PyPy includes modified Python 2.7 tests for testing compatibility. Some of changes skips tests for features that are not implemented in PyPy or are CPython specific, some reflects differences between error types or messages in CPython and PyPy, some are