[issue25139] Just a little refactoring

2015-09-18 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe this is equivalent. In general, bare excepts should be either made more specific or commented as intentional. Since derived classes can override finish_request, and fail any which way, the latter is probably appropriate here: # derived classes m

[issue25139] Just a little refactoring

2015-09-16 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> patch review versions: +Python 3.6 -Python 3.5 ___ Python tracker ___ ___ Python-bugs-list ma

[issue25139] Just a little refactoring

2015-09-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail

[issue25139] Just a little refactoring

2015-09-16 Thread Алексей Смирнов
New submission from Алексей Смирнов: https://github.com/python/cpython/blob/3.5/Lib/socketserver.py#L627 Must be: try: self.finish_request(request, client_address) except: self.handle_error(request, client_address) finally: self.shutdown_request(request) -- components: Librar