[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Brett Cannon]

Brett Cannon  added the comment:

imp has been moved to DeprecationWarning and I think its usage in the stdlib 
has been dealt with at this point.

--
resolution:  -> fixed
stage: needs patch -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Łukasz Langa]

Łukasz Langa  added the comment:

I meant to comment on a different issue, the trigger is stuff like 
https://bugs.python.org/issue39015 (new deprecationwarnings being generated 
without cleaning up the standard library first).

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Łukasz Langa]

Łukasz Langa  added the comment:

Make sure the standard library doesn't emit those warnings itself.

--
nosy: +lukasz.langa

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Brett Cannon]

Brett Cannon  added the comment:

> Any reason to keep imp there?

Nope, not anymore.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Batuhan]

Batuhan  added the comment:

@vstinner 

> Tools/importbench/importbench.py:10:import imp
> I think that it's fine to keep imp there. 

Any reason to keep imp there? We can just port it to sole importlib (it already 
uses it in some places)

--
nosy: +BTaskaya

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Nick Coghlan]

Nick Coghlan  added the comment:

Oops, this covers more than just modulefinder - reopening until the other 
remaining uses of the imp module have been removed.

--
resolution: fixed -> 
stage: resolved -> needs patch
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Nick Coghlan]

Nick Coghlan  added the comment:

Fixed for Python 3.8 via the patch for #35936.

--
nosy: +ncoghlan
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Brandt Bucher]

Change by Brandt Bucher :


--
pull_requests: +11786
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Brandt Bucher]

Change by Brandt Bucher :


--
pull_requests: +11786, 11787
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Berker Peksag]

Berker Peksag added the comment:

> - 2to3 replaces reload() calls with imp.reload

There is an already open issue for this: Issue 21446.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

One more:

- lib/pkgutil.py in _import_imp (amusingly) uses importlib with silenced 
warnings to import imp.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Jelle Zijlstra]

Changes by Jelle Zijlstra :


--
keywords: +patch
Added file: http://bugs.python.org/file43113/issue25160-2to3.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Jelle Zijlstra]

Jelle Zijlstra added the comment:

Current status:

- 2to3 replaces reload() calls with imp.reload
- Lib/modulefinder.py imports imp and uses it 10 or so times, mostly for 
constants
- Lib/xml/sax/__init__.py uses imp on Jython only
- Python/makeopcodetargets.py falls back to imp if importlib is not available. 
- Tools/importbench/importbench.py uses imp a number of times.

I'll work on replacing some of these.

--
nosy: +Jelle Zijlstra

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[STINNER Victor]

STINNER Victor added the comment:

> Tools/i18n/pygettext.py:159:import imp

I opened the issue #26639 for it.


>> Python/makeopcodetargets.py:9:import imp
> See issue 20021.

I pushed the change f682b620c64d but I forgot about the issue #20021. Let's 
discuss there about this script.


> Tools/importbench/importbench.py:10:import imp

I think that it's fine to keep imp there.


> Lib/modulefinder.py:14:import imp

This one requires more work than the other.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[STINNER Victor]

Changes by STINNER Victor :


--
nosy: +eric.snow

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
nosy: +Arfrever

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Roundup Robot]

Roundup Robot added the comment:

New changeset 03cd8340e0ce by Victor Stinner in branch '3.5':
Issue #25160: Fix import_init() comments and messages
https://hg.python.org/cpython/rev/03cd8340e0ce

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[STINNER Victor]

New submission from STINNER Victor:

The imp module is deprecated since Python 3.4. In Python 3.4, imp uses a 
PendingDeprecationWarning, and Python 3.5... hum, still a 
PendingDeprecationWarning. It was not supposed to become a real 
DeprecationWarning?

Anyway, the imp module is still used in some places of the Python stdlib:

Lib/modulefinder.py:14:import imp
Python/makeopcodetargets.py:9:import imp
Tools/i18n/pygettext.py:159:import imp
Tools/importbench/importbench.py:10:import imp

modulefinder explicitly ignore the warning :-(

with warnings.catch_warnings():
warnings.simplefilter('ignore', PendingDeprecationWarning)
import imp

--
messages: 250946
nosy: brett.cannon, haypo
priority: normal
severity: normal
status: open
title: Stop using deprecated imp module; imp should now emit a real 
DeprecationWarning
versions: Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Berker Peksag]

Berker Peksag added the comment:

> Python/makeopcodetargets.py:9:import imp

See issue 20021.

--
components: +Library (Lib)
nosy: +berker.peksag
stage:  -> needs patch
type:  -> enhancement
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

[Berker Peksag]

Berker Peksag added the comment:

> Lib/modulefinder.py:14:import imp

I forgot to link issue 20020 in my earlier message :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com