[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Roundup Robot added the comment: New changeset cc42700abb8e by Brett Cannon in branch '2.7': Issue #25188: Clean up code to pass the --pgo flag to subprocesses https://hg.python.org/cpython/rev/cc42700abb8e -- ___ Python tracker

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: Thanks for the patch, Arfrever. Although next time you don't need to unset every field of the issue since the issue was still fixed, just in a suboptimal fashion that didn't impact performance. -- resolution: -> fixed stage: -> resolved status: open

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Arfrever Frehtes Taifersar Arahesis added the comment: > New changeset 136ad559fa4f by Brett Cannon in branch '2.7': > Issue #25188: Add -P/--pgo to test.regrtest for PGO building. > https://hg.python.org/cpython/rev/136ad559fa4f > > +# required to permit running tests with

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Alecsandru Patrascu added the comment: Thank you Brett for your effort to merge all the changes made to regrtest despite the changes appeared on the way! -- ___ Python tracker

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: Here is a patch for Python 3.6. I'll commit this after I eat before Victor changes something else. =) -- Added file: http://bugs.python.org/file40662/issue25188-py36.diff ___ Python tracker

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Roundup Robot added the comment: New changeset fb90425017e3 by Brett Cannon in branch '3.5': Issue #25188: Add a -P/--pgo flag to regrtest to silence error output. https://hg.python.org/cpython/rev/fb90425017e3 New changeset c1ecb258003b by Brett Cannon in branch 'default': Merge from 3.5 for

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: Thanks for the initial patch, Alecsandru! May I not have to touch regrtest until after Victor is done doing whatever he is doing to it in 3.6. =) -- resolution: -> fixed stage: -> resolved status: open -> closed ___

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Roundup Robot added the comment: New changeset 136ad559fa4f by Brett Cannon in branch '2.7': Issue #25188: Add -P/--pgo to test.regrtest for PGO building. https://hg.python.org/cpython/rev/136ad559fa4f -- ___ Python tracker

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Alecsandru Patrascu added the comment: Thank you for the tweaks. I tested the patch and it is all working fine. Without failure count the PGO run is even more transparent to the user. I tested your final version of the patch on several Linux server and regular desktop distributions and

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: I fixed my test_eintr problem, but now https://hg.python.org/cpython/rev/4a9418ed0d0c landed in 3.6/default and broke the patch. Since missing getting this in before the aforementioned change was my fault, I'll personally handle making the patch apply cleanly

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: I should mention I would have committed my patch but test_einter is hanging for me, so if someone else wants to test the patch and verify it works then I can commit it. -- assignee: -> brett.cannon ___ Python

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: Here is a tweaked 3.6 patch so that --pgo doesn't even emit the failure count so you really can't tell what is going on unless some error info from the test spews out on to the shell (which I can't seem to stop since 2>/dev/null causes a test failure).

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40547/regrtest_36_v02.patch ___ Python tracker ___

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: Ah, OK. As I said I had not run it so I wasn't sure of the actual outcome. =) As for keyword-only arguments/parameters, see https://www.python.org/dev/peps/pep-3102/ . They are a Python 3 feature. -- ___ Python

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Brett Cannon added the comment: I left some comments on the Python 3.6 version of the patch. I don't know if we should apply such a change to Python 2.7 or 3.5, though, as it is a new feature of regrtest and thus runs the risk of breaking stuff. Then again, we have said that anything in the

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Alecsandru Patrascu added the comment: The patch does not display dots, as they are not that intuitive and users cannot make an estimate of the time left or the position in the training phase. Instead, the regrtest.py, will display the progress as [X/Y], like the default version, but without

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Changes by Alecsandru Patrascu : -- keywords: +patch Added file: http://bugs.python.org/file40532/regrtest_27.patch ___ Python tracker

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Changes by Alecsandru Patrascu : Added file: http://bugs.python.org/file40533/regrtest_36.patch ___ Python tracker ___

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Alecsandru Patrascu added the comment: I've added the patches for Python default and 2.7. To apply them please use the command "hg import --no-commit". PGO flag is implemented for both variants (single and multi process). Default in profile-opt will be single process. --

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

Changes by Brett Cannon : -- nosy: +brett.cannon ___ Python tracker ___ ___

[issue25188] regrtest.py improvement for Profile Guided Optimization builds

New submission from Alecsandru Patrascu: This issue adds improved support for Profile Guided Optimization builds in the regression test suite. Mainly, we keep the visual progress status in this process and suppress errors or any other unnecessary output that can alarm users. --