[issue25211] Error message formatting errors in int object unit-test script

Roundup Robot added the comment: New changeset 697781ff3b49 by Martin Panter in branch '3.4': Issue #25211: Eliminate lazy error message class by using subTest https://hg.python.org/cpython/rev/697781ff3b49 New changeset 6e11708dcb3b by Martin Panter in branch '3.5': Issue #25211: Merge

[issue25211] Error message formatting errors in int object unit-test script

Changes by Martin Panter : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker ___

[issue25211] Error message formatting errors in int object unit-test script

Berker Peksag added the comment: subTest-long.patch looks good to me. Thanks! -- stage: patch review -> commit review ___ Python tracker ___

[issue25211] Error message formatting errors in int object unit-test script

Martin Panter added the comment: I will commit your patch to 2.7. Here is a my alternative proposal for 3.4+, dropping the Frm class and using subTest() instead. I kept some error messages where I thought they added clarity, but dropped most because I thought they were redundant with the test

[issue25211] Error message formatting errors in int object unit-test script

Roundup Robot added the comment: New changeset e2f1f69d0618 by Martin Panter in branch '2.7': Issue #25211: Fix error message code in test_long; patch from s-wakaba https://hg.python.org/cpython/rev/e2f1f69d0618 -- nosy: +python-dev ___ Python

[issue25211] Error message formatting errors in int object unit-test script

Martin Panter added the comment: Thanks for the patch, it looks correct. The Frm class takes a variable number of *args, and then returns “format % args”. It should at least be applied to the 2.7 branch. For 3.4+, perhaps we can eliminate the need for the Frm class altogether, by using

[issue25211] Error message formatting errors in int object unit-test script

New submission from s-wakaba: I've found some parts there are illegal message formatting in int object unit test script "Lib/test/test_long.py" when hacking the interpreter. because they were an easy problem, I already fixed them to promote my work. Therefore, the patch has been attacked.