[issue25246] Alternative algorithm for deque_remove()

Change by Raymond Hettinger : -- resolution: rejected -> fixed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue25246] Alternative algorithm for deque_remove()

Raymond Hettinger added the comment: New changeset 6b1ac809b9718a369aea67b99077cdd682be2238 by Raymond Hettinger in branch 'master': bpo-25246: Optimize deque.remove() (GH-23898) https://github.com/python/cpython/commit/6b1ac809b9718a369aea67b99077cdd682be2238 --

[issue25246] Alternative algorithm for deque_remove()

Raymond Hettinger added the comment: Created a new PR that gives a substantial speed-up while keeping the API unchanged and while closely matching the logic for list.remove(). -- ___ Python tracker

[issue25246] Alternative algorithm for deque_remove()

Change by Raymond Hettinger : -- pull_requests: +22753 pull_request: https://github.com/python/cpython/pull/23898 ___ Python tracker ___

[issue25246] Alternative algorithm for deque_remove()

Raymond Hettinger added the comment: Am closing this one because it isn't worth an API change. The remove() method is little used and to the extent people do use it, they expect it to work like list.remove(). The latter never raises a RuntimeError. -- resolution: -> rejected

[issue25246] Alternative algorithm for deque_remove()

Change by Pablo Galindo Salgado : -- pull_requests: +9221 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25246] Alternative algorithm for deque_remove()

Change by Pablo Galindo Salgado : -- pull_requests: +7285 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25246] Alternative algorithm for deque_remove()

Tal Einat added the comment: IMO both approaches sound better than the existing implementation. Better to choose one than to do nothing. -- nosy: +taleinat ___ Python tracker

[issue25246] Alternative algorithm for deque_remove()

Change by Raymond Hettinger : -- priority: normal -> low versions: +Python 3.8 -Python 3.6 ___ Python tracker ___

[issue25246] Alternative algorithm for deque_remove()

Serhiy Storchaka added the comment: There is more optimal approach. Find not just an index in a deque, but a block and an index in a block. After that move left or right part of a deque one position right or left. __delitem__() could be 2 times faster, remove() could be faster too. Helpers

[issue25246] Alternative algorithm for deque_remove()

New submission from Raymond Hettinger: The current algorithm for remove() rotates the deque one-by-one until a match is found, pops it off the deque and does single mass rotate to undo the 1-step rotates. An alternative approach is to use deque_index() to locate the value of interest and use