[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Gregory P. Smith]

Change by Gregory P. Smith :


--
resolution:  -> fixed
stage: patch review -> commit review
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[miss-islington]

miss-islington  added the comment:


New changeset d1a97b36595726074a83452e5c476806936becba by Miss Islington (bot) 
in branch '3.7':
[3.7] bpo-25438: document what codec PyMemberDef T_STRING decodes the char * as 
(GH-10580) (GH-10586)
https://github.com/python/cpython/commit/d1a97b36595726074a83452e5c476806936becba


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[miss-islington]

miss-islington  added the comment:


New changeset 8945017be4cc9527767bb66673e73e28e4b0b4d3 by Miss Islington (bot) 
in branch '3.6':
[3.6] bpo-25438: document what codec PyMemberDef T_STRING decodes the char * as 
(GH-10580) (GH-10587)
https://github.com/python/cpython/commit/8945017be4cc9527767bb66673e73e28e4b0b4d3


--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[miss-islington]

Change by miss-islington :


--
pull_requests: +9831

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[miss-islington]

Change by miss-islington :


--
pull_requests: +9830

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[miss-islington]

miss-islington  added the comment:


New changeset 689d555ec135d4115574addd063c358ac4897cc4 by Miss Islington (bot) 
(Windson yang) in branch 'master':
bpo-25438: document what codec PyMemberDef T_STRING decodes the char * as 
(GH-10580)
https://github.com/python/cpython/commit/689d555ec135d4115574addd063c358ac4897cc4


--
nosy: +miss-islington

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Windson Yang]

Change by Windson Yang :


--
keywords: +patch
pull_requests: +9824
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Windson Yang]

Change by Windson Yang :


--
keywords: +patch, patch
pull_requests: +9824, 9826
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Windson Yang]

Change by Windson Yang :


--
keywords: +patch, patch, patch
pull_requests: +9824, 9825, 9826
stage: needs patch -> patch review

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Windson Yang]

Windson Yang  added the comment:

I will work on it today :D

--
nosy: +Windson Yang

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Gregory P. Smith]

Gregory P. Smith  added the comment:

it still seems relevant, having better docs is always good.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Lysandros Nikolaou]

Lysandros Nikolaou  added the comment:

It's been more than 3 years, since this was opened, but I will ask 
nevertheless. Should a PR maybe made for this issue?

--
nosy: +lys.nikolaou

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Josh Rosenberg]

Josh Rosenberg added the comment:

Checking the source ( 
https://hg.python.org/cpython/file/tip/Python/structmember.c#l51 ), it calls 
PyUnicodeFromString ( 
https://docs.python.org/3/c-api/unicode.html?highlight=pyunicode_fromstring#c.PyUnicode_FromString
 ), so it's always interpreted as UTF-8.

--
nosy: +josh.r

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25438] document what codec PyMemberDef T_STRING decodes the char * as

[Gregory P. Smith]

New submission from Gregory P. Smith:

https://docs.python.org/3/c-api/structures.html#c.PyMemberDef

T_STRING members are turned into str objects in Python.  The documentation 
needs updating to mention which codec the char * bytes are treated as.

Solving this issue involves code inspection and leaving pointers to that code 
here in the issue, then updating the docs to mention the requirements for the 
char * member data as well as what happens upon assignment for non-READONLY 
T_STRING data (a different restriction?  or encoding to the same codec?)

My _guess_ would be UTF-8 or ASCII but I'll let someone else dive in and find 
out.  This is a Python 3 specific documentation clarification.

--
assignee: docs@python
components: Documentation
keywords: easy
messages: 253172
nosy: docs@python, gregory.p.smith
priority: normal
severity: normal
stage: needs patch
status: open
title: document what codec PyMemberDef T_STRING decodes the char * as
type: behavior
versions: Python 3.4, Python 3.5, Python 3.6

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com