[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Alex Gaynor
Alex Gaynor added the comment: (Note that the speed difference would be even bigger on a recent python, 2.7.3 was before the file descriptor was cached for os.urandom) -- ___ Python tracker

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Alex Gaynor
New submission from Alex Gaynor: Right now uuid4 can be implemented one of 3 ways: - If there's a libuuid (and it's not OS X's) it uses that. - Fallback to os.urandom - If that raises an exception, fall back to the random module I propose to simplify this to _just_ use os.urandom always.

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: On Oct 29, 2015, at 10:30 PM, Alex Gaynor wrote: >Right now uuid4 can be implemented one of 3 ways: If you're hacking on the uuid module, keep in mind issue22807 -- nosy: +barry ___ Python tracker

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread John Mark Vandenberg
Changes by John Mark Vandenberg : -- nosy: +John.Mark.Vandenberg ___ Python tracker ___ ___

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Roundup Robot
Roundup Robot added the comment: New changeset 24bdc4940e81 by Benjamin Peterson in branch '2.7': always use os.urandom for the uuid4 algorithm (closes #25515) https://hg.python.org/cpython/rev/24bdc4940e81 New changeset 70be1f9c9255 by Benjamin Peterson in branch '3.5': always use os.urandom

[issue25515] Always use os.urandom for generating uuid4s

2015-10-29 Thread Donald Stufft
Donald Stufft added the comment: This looks like a good idea to me, faster and more secure seems like a total win. -- ___ Python tracker ___