[issue25616] Extract OrderedDict tests into separate file

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

Thank you Raymond. Here is a patch. It is in Git format, hence Rietveld will 
not work with it. During creating a patch I found a bug in test_dict_update, it 
tested only default implementation and didn't test subclasses.

--
keywords: +patch
stage:  -> patch review
versions: +Python 2.7, Python 3.4, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41056/test_ordered_dict.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25616] Extract OrderedDict tests into separate file

[Raymond Hettinger]

Raymond Hettinger added the comment:

If it helps with all the great work you're doing, go ahead and move the OD 
tests out to a separate file.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25616] Extract OrderedDict tests into separate file

[Eric Snow]

Eric Snow added the comment:

FWIW, I totally support this.  I originally had a patch up that did so but 
Raymond indicated that he'd rather not split the tests out though I made 
exactly the same arguments that you have.  Perhaps he's changed his mind in the 
intervening years (or I misunderstood his objections)? :)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25616] Extract OrderedDict tests into separate file

[Serhiy Storchaka]

New submission from Serhiy Storchaka:

OrderedDict tests now are about 1/3 of test_collections, and I think their 
volume will grow. I suggest to extract these tests into separate file 
test_ordereddict. There are precedences: test_deque (deque also is implemented 
in C), and test_userdict, test_userlist and test_userstring (for historical 
reasons).

The main reason to me is the possibility to run quick OrderedDict tests (and 
only OrderedDict tests).

--
components: Tests
messages: 254602
nosy: eric.snow, rhettinger, serhiy.storchaka
priority: normal
severity: normal
status: open
title: Extract OrderedDict tests into separate file
type: enhancement

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com