[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

STINNER Victor added the comment: > Please go ahead with bininstall-3.patch if you prefer. Ok done. > It certainly avoids the problem you reported. Although I still encourage you > to not add the dash before the command. Oops, fixed. -- resolution: -> fixed status: open -> closed

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Roundup Robot added the comment: New changeset 94910d210ef4 by Victor Stinner in branch '2.7': Issue #25696: Don't ignore errors in 'make bininstall' on creating $(LIBPC) directory https://hg.python.org/cpython/rev/94910d210ef4 New changeset d28268c47421 by Victor Stinner in branch '3.5':

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Roundup Robot added the comment: New changeset c03ef448b5b2 by Victor Stinner in branch '2.7': Issue #25696: Fix installation of Python on UNIX with make -j9. https://hg.python.org/cpython/rev/c03ef448b5b2 New changeset 87d96b349ff5 by Victor Stinner in branch '3.5': Issue #25696: Fix

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Martin Panter added the comment: Please go ahead with bininstall-3.patch if you prefer. It certainly avoids the problem you reported. Although I still encourage you to not add the dash before the command. -- ___ Python tracker

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

STINNER Victor added the comment: bininstall-4.patch: IMHO it's overkill and makes Makefile more complex to follow. My patch bininstall.patch proposed something similar, but Arfrever asked me to modify bininstall target. IMHO Getting "Creating directory xxx" message twice is a minor issue.

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Changes by Martin Panter : Added file: http://bugs.python.org/file41178/bininstall-4.patch ___ Python tracker ___

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Martin Panter added the comment: I agree your patches should fix your practical bug (I can reproduce it, two out of three times). My concern is more about making the code cleaner and less likely to grow problems in the future. :) The worse case with patch 3 would be the “Creating directory”

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

STINNER Victor added the comment: > $(LIBPC) is a single directory name, so I suggest dropping the “for” loop. Ok, here is a version without loop. I also added "-" before the if to mimick other lines of the bininstall target. Does it look better now? > (...) there is technically still a race

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Martin Panter added the comment: $(LIBPC) is a single directory name, so I suggest dropping the “for” loop. Patch 2 should avoid the practical race condition. But there is technically still a race with “libainstall” and “bininstall” both testing and creating the same directory. Maybe we

[issue25696] "make -j9 install" fails because bininstall target requires the libainstall target

Changes by STINNER Victor : -- title: "MAKEFLAGS=-j9 make install" fails because bininstall target requires the libainstall target -> "make -j9 install" fails because bininstall target requires the libainstall target ___