[issue25742] locale.setlocale does not work with unicode strings

[Arfrever Frehtes Taifersar Arahesis]

Changes by Arfrever Frehtes Taifersar Arahesis :


--
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Serhiy Storchaka]

Serhiy Storchaka added the comment:

http://buildbot.python.org/all/builders/x86%20XP-4%202.7/builds/3517/steps/test/logs/stdio
==
ERROR: test_setlocale_unicode (test.test_locale.TestMiscellaneous)
--
Traceback (most recent call last):
  File 
"d:\cygwin\home\db3l\buildarea\2.7.bolen-windows\build\lib\test\test_locale.py",
 line 497, in test_setlocale_unicode
old_loc = locale.getlocale(locale.LC_ALL)
  File "d:\cygwin\home\db3l\buildarea\2.7.bolen-windows\build\lib\locale.py", 
line 565, in getlocale
raise TypeError, 'category LC_ALL is not supported'
TypeError: category LC_ALL is not supported

--

--
nosy: +serhiy.storchaka
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Roundup Robot]

Roundup Robot added the comment:

New changeset d7481ebeaa4f by Victor Stinner in branch '2.7':
Issue #25742: Try to fix test_locale on Windows
https://hg.python.org/cpython/rev/d7481ebeaa4f

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[STINNER Victor]

STINNER Victor added the comment:

I don't see the benefit of supporting Unicode strings for setlocale() 
arguments: locale name are always encodable to ASCII, so loc.decode('ascii') is 
enough to workaround the issue.

But well, I think it's ok if it doesn't make the code much more complex ;-)

I wrote a patch, what do you think? Is it worth it? ;-)

--
keywords: +patch
Added file: http://bugs.python.org/file41175/setlocale_unicode.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[STINNER Victor]

STINNER Victor added the comment:

Marc-Andre Lemburg added the comment:
> No big deal. There are probably lots more places in the stdlib which
> break without Unicode compiled in... :-)

Well, to have more fun, try to run any Python application with a
Python compiled without Unicode support *and* without thread support
:-D

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

I wouldn't say this is a feature request. 

What the code wanted to check is "if this is an iterable of two strings, 
convert these to a locale string". I have no idea why the doc string uses 
"iterable". IMO, a tuple of two strings would have been fine and make the test 
case a lot simpler - too late to fix, though.

If the code works with Unicode strings, I think we can change the test to:

if locale and not isinstance(locale, basestring):
...

In Python 3, the function will only accept Unicode strings, so no need to fix 
things there.

@tierlieb: Could you provide a patch with test for this ? Thanks.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Roundup Robot]

Roundup Robot added the comment:

New changeset 7841e9b614eb by Victor Stinner in branch '2.7':
Closes #25742: locale.setlocale() now accepts a Unicode string for its second
https://hg.python.org/cpython/rev/7841e9b614eb

--
nosy: +python-dev
resolution:  -> fixed
stage:  -> resolved
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 27.11.2015 23:50, STINNER Victor wrote:
> 
> STINNER Victor added the comment:
> 
>> BTW: Why did you use (_str, _unicode) instead of basestring ?
> 
> Serhiy usually insists that technically, it's possible to compile Python 2.7 
> without Unicode support. I don't believe that anyone uses this crazy feature, 
> but well, it was easier to use _unicode (which is already defined) than 
> trying to run a poll on python users :-)

Hmm, but basestring is always defined, even when Python is compiled
without Unicode support (which I agree is not used much these
days). unicode won't exist in such a Python version, so basestring
is actually safer to use than the tuple.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 27.11.2015 23:11, STINNER Victor wrote:
> 
> STINNER Victor added the comment:
> 
> I don't see the benefit of supporting Unicode strings for setlocale() 
> arguments: locale name are always encodable to ASCII, so loc.decode('ascii') 
> is enough to workaround the issue.
> 
> But well, I think it's ok if it doesn't make the code much more complex ;-)
> 
> I wrote a patch, what do you think?

Thanks :-)

> Is it worth it? ;-)

I think so, since the current failure for Unicode is rather
obscure.

BTW: Why did you use (_str, _unicode) instead of basestring ?

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[STINNER Victor]

STINNER Victor added the comment:

Marc-Andre Lemburg added the comment:
> Hmm, but basestring is always defined, even when Python is compiled
> without Unicode support (...)

Oh, I didn't know. Well, I already pushed my patch and it works. Feel
free to modify locale.py to use basestring. I'm not interested to
spend time on this *minor* issue anymore ;-)

Thanks for the review.by the way.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[STINNER Victor]

STINNER Victor added the comment:

> BTW: Why did you use (_str, _unicode) instead of basestring ?

Serhiy usually insists that technically, it's possible to compile Python 2.7 
without Unicode support. I don't believe that anyone uses this crazy feature, 
but well, it was easier to use _unicode (which is already defined) than trying 
to run a poll on python users :-)

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[Marc-Andre Lemburg]

Marc-Andre Lemburg added the comment:

On 28.11.2015 00:00, STINNER Victor wrote:
> 
> STINNER Victor added the comment:
> 
> Marc-Andre Lemburg added the comment:
>> Hmm, but basestring is always defined, even when Python is compiled
>> without Unicode support (...)
> 
> Oh, I didn't know. Well, I already pushed my patch and it works. Feel
> free to modify locale.py to use basestring. I'm not interested to
> spend time on this *minor* issue anymore ;-)

No big deal. There are probably lots more places in the stdlib which
break without Unicode compiled in... :-)

> Thanks for the review.by the way.

Thanks for the patch.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue25742] locale.setlocale does not work with unicode strings

[tierlieb]

New submission from tierlieb:

Within locale.py in setlocale your have this piece of code:

if locale and type(locale) is not type(""):
# convert to string
locale = normalize(_build_localename(locale))

That does not work with unicode strings as I found out after wondering quite a 
bit about the difference was between my tests and my production code...

So either expand the check here to include type(u"") or make _build_localename 
smarter.

--
components: Unicode
messages: 255461
nosy: ezio.melotti, haypo, tierlieb
priority: normal
severity: normal
status: open
title: locale.setlocale does not work with unicode strings
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com