[issue2576] httplib read() very slow due to lack of socket buffer

Antoine Pitrou added the comment: This was apparently fixed in r69209. -- resolution: -> out of date status: open -> closed ___ Python tracker ___ __

[issue2576] httplib read() very slow due to lack of socket buffer

Chris Withers added the comment: Yep, having done some more extensive profiling, it looks like my issue is different: all the time is being spent in httplib's HTTPResponse._read_chunked. That wouldn't be a symptom of this issue, would it? -- ___ P

[issue2576] httplib read() very slow due to lack of socket buffer

Gregory P. Smith added the comment: I am also unable to reproduce the reported problem using the pastebin.ca/973578 code. The time to download 400mb from localhost remains the same regardless of buffering=False (default) or True. The problem still exists but it is better described in issue1542

[issue2576] httplib read() very slow due to lack of socket buffer

Gregory P. Smith added the comment: trunk r74463 now forces the HTTPResponse with buffering=True to close afterwards using a HTTPResponse._must_close flag similar to what was suggested in buffered_socket.diff in this issue. -- ___ Python tracker

[issue2576] httplib read() very slow due to lack of socket buffer

Gregory P. Smith added the comment: Anything that adds a new parameter can not be backported to 2.6 as that counts as an API change / feature addition. -- ___ Python tracker ___

[issue2576] httplib read() very slow due to lack of socket buffer

Chris Withers added the comment: Why not allow True or an integer as values for a buffer_size parameter to the HTTPConnection constructor. False would be the default, which would mean "no buffering" as currently is the case. True would mean use buffering of the default size and an integer val

[issue2576] httplib read() very slow due to lack of socket buffer

Gregory P. Smith added the comment: Okay, I do not think this has been fixed yet. Anyone calling getresponse() can indeed use buffering=True, it can mess things up if the do not close the connection afterwards. The addition of the sockbuf parameter to HTTPConnection as proposed in buffered_soc

[issue2576] httplib read() very slow due to lack of socket buffer

Gregory P. Smith added the comment: Note that http://bugs.python.org/issue4879 may have already fixed this problem in trunk r68532. -- nosy: +gregory.p.smith ___ Python tracker _

[issue2576] httplib read() very slow due to lack of socket buffer

Changes by Gabriel Genellina : -- nosy: +gagenellina ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail

[issue2576] httplib read() very slow due to lack of socket buffer

Chris Withers added the comment: Well, for me, buffer size doesn't appear to have made any difference... -- ___ Python tracker ___ ___

[issue2576] httplib read() very slow due to lack of socket buffer

Antoine Pitrou added the comment: I must admit I don't understand the conflict between buffering and pipelined requests. This is all sequential reading and the buffer should be transparent, shouldn't it? -- nosy: +pitrou versions: +Python 2.7, Python 3.1, Python 3.2 ___

[issue2576] httplib read() very slow due to lack of socket buffer

Chris Withers added the comment: I tried to use the following to change the buffersize for a download: from base64 import encodestring from httplib import HTTPResponse,HTTPConnection,HTTPSConnection,_UNKNOWN from datetime import datetime class FHTTPResponse(HTTPResponse): def __init__(sel

[issue2576] httplib read() very slow due to lack of socket buffer

Changes by Ralf Schmitt <[EMAIL PROTECTED]>: -- nosy: +schmir __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubscribe:

[issue2576] httplib read() very slow due to lack of socket buffer

Daniel Diniz <[EMAIL PROTECTED]> added the comment: Also reported in #1542407 __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsubs

[issue2576] httplib read() very slow due to lack of socket buffer

Daniel Diniz <[EMAIL PROTECTED]> added the comment: "The code patch is trivial", he said, only to find out it was not :) Facundo, thanks in advance for taking a look at this! This patch tries to implement, document and test an optional argument to HTTPConnection, which passes it to HTTPResponse

[issue2576] httplib read() very slow due to lack of socket buffer

Facundo Batista <[EMAIL PROTECTED]> added the comment: Daniel, Aren, please submit also what Daniel described, and I'll take a look and push it forward. Regards, -- nosy: +facundobatista __ Tracker <[EMAIL PROTECTED]> _

[issue2576] httplib read() very slow due to lack of socket buffer

Daniel Diniz <[EMAIL PROTECTED]> added the comment: The code patch is trivial. I believe it needs docs (both explaining how to use and warning against the problems it may cause), a NEWS entry and tests (at least to check what happens when an invalid value lands). I can work on those changes if t

[issue2576] httplib read() very slow due to lack of socket buffer

Changes by Gregory P. Smith <[EMAIL PROTECTED]>: -- priority: -> high __ Tracker <[EMAIL PROTECTED]> __ ___ Python-bugs-list mailing list Unsu

[issue2576] httplib read() very slow due to lack of socket buffer

New submission from Aren Olson <[EMAIL PROTECTED]>: This is a reposting of issue 508157, as requested by gvanrossum. The socket file object in httplib is opened without any buffering resulting in very slow performance of read(). The specific problem is in the httplib.HTTPResponse constructor.