[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Zachary Ware
Zachary Ware added the comment: STINNER Victor added the comment: > Can you please check if the branch 3.5 is impacted? It is. -- ___ Python tracker ___

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread STINNER Victor
STINNER Victor added the comment: > How am I supposed to start? Can you please check if the branch 3.5 is impacted? -- ___ Python tracker ___

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Felippe da Motta Raposo
Felippe da Motta Raposo added the comment: I did it! Can you please take a look at it? -- keywords: +patch Added file: http://bugs.python.org/file41241/mywork.patch ___ Python tracker

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Martin Panter
Martin Panter added the comment: Either patch looks good to me. I don’t have a strong opinion about unittest.TestCase. I left a comment about adding the module=... back in test_pyclbr. -- nosy: +martin.panter stage: needs patch -> patch review ___

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Felippe da Motta Raposo
Felippe da Motta Raposo added the comment: SilentGhost suggested that I should change all occurrences of `TestCase`, on both `test_telnetlib` and `test_pyclbr`, by `unittest.TestCase`. This patch has these changes. -- Added file: http://bugs.python.org/file41244/mywork.patch

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Felippe da Motta Raposo
Felippe da Motta Raposo added the comment: Martin Panter added the comment: > I left a comment about adding the module=... back in test_pyclbr. I had to put it because `test_others` was failing: (test output) ``` l1=['TestCase'] l2=['unittest.TestCase'] ignore={'object'} class= FAIL

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Zachary Ware
Zachary Ware added the comment: I'd rather leave things as they were, just add ', main as unittest_main' to the existing 'from unittest import TestCase' and change the call at the end from 'unittest.main()' to 'unittest_main()'. Felippe, have you signed a contributor agreement? If not, it

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Roundup Robot
Roundup Robot added the comment: New changeset a54ee6a65f10 by Zachary Ware in branch '3.5': Issue #25795: Fix several tests to run independently. https://hg.python.org/cpython/rev/a54ee6a65f10 New changeset 401459dca320 by Zachary Ware in branch 'default': Closes #25795: Merge with 3.5

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Zachary Ware
Zachary Ware added the comment: I made the change to test_pyclbr that I mentioned and committed it. Thanks, Fellipe! -- ___ Python tracker ___

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Zachary Ware
Changes by Zachary Ware : -- title: test_fork1 cannot be run directly: ./pyhon Lib/test/test_fork1.py -> test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py ___ Python tracker

[issue25795] test_fork1 cannot be run directly: ./python Lib/test/test_fork1.py

2015-12-04 Thread Felippe da Motta Raposo
Felippe da Motta Raposo added the comment: I'd like to fix it! How am I supposed to start? -- nosy: +felippemr ___ Python tracker ___