[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Martin Panter added the comment: I made some simple tweaks to avoid long lines. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Roundup Robot added the comment: New changeset 92947704321c by Martin Panter in branch 'default': Issue #25951: Fix SSLSocket.sendall() to return None, by Aviv Palivoda https://hg.python.org/cpython/rev/92947704321c -- nosy: +python-dev ___ Python

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Martin Panter added the comment: Thanks for your work Aviv. This version looks good to me. -- versions: -Python 3.5 ___ Python tracker ___

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Aviv Palivoda added the comment: Thanks for the review. I don't have any use cases for this change. I just saw this issue while looking for something else and thought I will give it a try. -- Added file: http://bugs.python.org/file42285/25951-2.patch

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Martin Panter added the comment: Agreed that the documentation and implementation should match. But this seems like a rather low-priority bug. What use case relies on the return value being None? If there is no immediate need for this change, it might be safer to just make it in 3.6, to

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Aviv Palivoda added the comment: Changed SSLSocket.sendall() to return None. Also added a check of the return value of the SSLSocket.send(), SSLSocket.sendall() in the tests. -- keywords: +patch nosy: +palaviv Added file: http://bugs.python.org/file42278/25951.patch

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

Changes by SilentGhost : -- nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou type: -> behavior versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker

[issue25951] SSLSocket.sendall() does not return None on success like socket.sendall()

New submission from ProgVal: socket.sendall() returns None if it succeeded SSLSocket.sendall() is said to have the same behavior as socket.sendall(), besides not allowing flags