[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Opened #27953 to track the issue with tan on OS X Tiger. Re-closing here. -- status: open -> closed ___ Python tracker ___ _

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: > or at least, no more unhappy than before Not quite true: test_math and test_cmath are failing for the x86 Tiger 3.x buildbot: == FAIL: test_testfile (test.test_math.MathTests) --

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Buildbots seem happy (or at least, no more unhappy than before). Closing. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: iss26040_v4.patch applied. I'm watching the buildbots; if everything looks good there, I'll close the issue. -- ___ Python tracker ___

[issue26040] Improve coverage and rigour of test.test_math

Roundup Robot added the comment: New changeset e3dbe8b7279a by Mark Dickinson in branch 'default': Issue #26040: Improve test_math and test_cmath coverage and rigour. Thanks Jeff Allen. https://hg.python.org/cpython/rev/e3dbe8b7279a -- ___ Python tra

[issue26040] Improve coverage and rigour of test.test_math

Jeff Allen added the comment: Ah, cunning: I can make sense of it in hex. >>> hex(to_ulps(expected)) '0x3ff0' >>> hex(to_ulps(got)) '0x3fec' >>> hex( to_ulps(got) - to_ulps(expected) ) '-0x4' ... and what you've done with ulp then follows. In my version a format like "{

[issue26040] Improve coverage and rigour of test.test_math

Jeff Allen added the comment: Mark: Thanks for doing my homework. Points 1 and 3 I can readily agree with. I must take another look at to_ulps() with your patch on locally. I used the approach I did because I thought it was incorrect in exactly those corners where you prefer it. I'll take a cl

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: One more version; increased the default ulp_tol to 5 everywhere, and made some minor style fixes in nearby code. -- Added file: https://bugs.python.org/file44254/iss26040_v4.patch ___ Python tracker

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: I've reviewed the test_math portion of the patch (which looks good, thank you!), and made a few revisions in iss26040_v3.patch. 1. I've rewritten the ulp() function to use struct. Same behaviour as before, but this way feels safer, since it doesn't rely on the

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: iss26040.patch didn't apply cleanly to master (because of the recent math.tau addition). Here's an updated patch. -- Added file: https://bugs.python.org/file44251/iss26040_v2.patch ___ Python tracker

[issue26040] Improve coverage and rigour of test.test_math

Jeff Allen added the comment: Mark: Thanks for validating the additional cases so carefully. If you still want to apply it in stages then I suppose the change to the comparison logic could go first (untested idea), although that's also where I could most easily have made a mistake. --

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Reverted in https://hg.python.org/cpython/rev/4389aa3507c5 -- ___ Python tracker ___ ___ Python-bugs

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Thanks, Ned. (And apologies.) The test_math tests are too strict in this case, which is one of the issues that Jeff's full patch fixes. It looks like my strategy of applying the patch in two pieces isn't going to work. I'll revert the change for now, and have

[issue26040] Improve coverage and rigour of test.test_math

Ned Deily added the comment: Mark, many buildbots are unhappy. For example: == FAIL: test_testfile (test.test_math.MathTests) -- Traceback (most recent call la

[issue26040] Improve coverage and rigour of test.test_math

Changes by koobs : -- nosy: +koobs ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.org/mail

[issue26040] Improve coverage and rigour of test.test_math

Roundup Robot added the comment: New changeset 1017215f5492 by Mark Dickinson in branch 'default': Issue #26040 (part 1): add new testcases to cmath_testcases.txt. Thanks Jeff Allen. https://hg.python.org/cpython/rev/1017215f5492 -- nosy: +python-dev ___

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: I finally have some time to look at this. I've double-checked all the new cmath testcases against MPFR (via bigfloat), and they all look good. I plan to apply this in two stages: (1) apply the new cmath testcases, (2) apply the test_math changes, and (1.5) wat

[issue26040] Improve coverage and rigour of test.test_math

Changes by Mark Dickinson : -- assignee: -> mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: htt

[issue26040] Improve coverage and rigour of test.test_math

Changes by Jeff Allen : Added file: http://bugs.python.org/file42191/extra_cmath_testcases.py ___ Python tracker ___ ___ Python-bugs-list mail

[issue26040] Improve coverage and rigour of test.test_math

Changes by Jeff Allen : Removed file: http://bugs.python.org/file42190/stat_math.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue26040] Improve coverage and rigour of test.test_math

Changes by Jeff Allen : Added file: http://bugs.python.org/file42192/stat_math.py ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue26040] Improve coverage and rigour of test.test_math

Changes by Jeff Allen : Removed file: http://bugs.python.org/file41526/stat_math.py ___ Python tracker ___ ___ Python-bugs-list mailing list U

[issue26040] Improve coverage and rigour of test.test_math

Mark Dickinson added the comment: Big +1 for the idea, and thank you for doing this work. I can't promise to find time to do a thorough review in the near future (though I'll try). -- ___ Python tracker __

[issue26040] Improve coverage and rigour of test.test_math

Jeff Allen added the comment: Thanks for the prompt acknowledgement and for accepting this to review. I have updated the coverage & tolerance demo program. Usage in the comments (in v3). I have also added the program I used to generate the extra test cases (needs mpmath -- easier to get worki

[issue26040] Improve coverage and rigour of test.test_math

Changes by Jeff Allen : Added file: http://bugs.python.org/file42190/stat_math.py ___ Python tracker ___ ___ Python-bugs-list mailing list Uns

[issue26040] Improve coverage and rigour of test.test_math

Changes by Serhiy Storchaka : -- nosy: +christian.heimes, eric.smith, lemburg, serhiy.storchaka, stutzbach versions: +Python 3.5 ___ Python tracker ___ __

[issue26040] Improve coverage and rigour of test.test_math

Jeff Allen added the comment: Here is a patch that improves coverage and addresses the uneven accuracy. Required accuracy is now specified in ulps. Mostly, I have choses 1 ulp, since this passed for me on an x86 architecture (and also ARM), but this may be too ambitious. I have also responded