[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Gregory P. Smith]

Changes by Gregory P. Smith :


--
resolution:  -> fixed
status: open -> closed

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Roundup Robot]

Roundup Robot added the comment:

New changeset 184dfef08a93 by Gregory P. Smith in branch '2.7':
issue26083: Avoid duplicate error message string from a subprocess exec 
failure.Avoid a duplicate error message string from a subprocess exec failure.
https://hg.python.org/cpython/rev/184dfef08a93

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Chi Hsuan Yen]

Chi Hsuan Yen added the comment:

Great point!

--
resolution: fixed -> 
status: closed -> open

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Alok Singhal]

Alok Singhal added the comment:

I think there is a small problem with the fix in changeset 268d13c7e939 
(msg258029).  It copies the string from the return value of _eintr_retry_call() 
twice.  I am attaching a trivial fix.

--
keywords: +patch
nosy: +AlokSinghal
Added file: http://bugs.python.org/file43034/subprocess.patch

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Gregory P. Smith]

Gregory P. Smith added the comment:

note: this was not a security issue nor was it a crash.  an exception was being 
raised anyways from the forked child prior to the exec(), this bug just caused 
that to be swallowed and this ValueError raised instead.

--
resolution:  -> fixed
stage:  -> commit review
status: open -> closed
type: crash -> behavior

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Roundup Robot]

Roundup Robot added the comment:

New changeset 268d13c7e939 by Gregory P. Smith in branch '2.7':
Fixes issue #26083: Workaround a subprocess bug that raised an incorrect
https://hg.python.org/cpython/rev/268d13c7e939

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Gregory P. Smith]

Gregory P. Smith added the comment:

I strongly recommend people use https://pypi.python.org/pypi/subprocess32/ 
instead of Python 2.7's subprocess module whenever possible.

That said, the fix is pretty easy.

--
assignee:  -> gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Eryk Sun]

Eryk Sun added the comment:

> I strongly recommend people use https://pypi.python.org/pypi/subprocess32/

I think this warrants a note that draws more attention to itself than the "see 
also" text.

--
nosy: +eryksun

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Ned Deily]

Changes by Ned Deily :


--
nosy: +gregory.p.smith

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26083] ValueError: insecure string pickle in subprocess.Popen on Python 2

[Chi Hsuan Yen]

New submission from Chi Hsuan Yen:

Originally reported at [1] and [2].

On Mac OS X, read() on pipes may return only the first 512 bytes. The remaining 
bytes are not read into `data` in _execute_child(). There's a patch proposal at 
[3]. I didn't test it myself because I can't reproduce the broken situation.

[1] https://github.com/rg3/youtube-dl/issues/6840
[2] https://github.com/matplotlib/matplotlib/issues/5386
[3] https://github.com/matplotlib/matplotlib/issues/5386#issuecomment-16817

--
components: Library (Lib), Macintosh
messages: 258011
nosy: Chi Hsuan Yen, ned.deily, ronaldoussoren
priority: normal
severity: normal
status: open
title: ValueError: insecure string pickle in subprocess.Popen on Python 2
type: crash
versions: Python 2.7

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com