[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-03-27 Thread Roundup Robot 

Roundup Robot added the comment:

New changeset a90f5e2b7160 by Berker Peksag in branch 'default':
Issue #26130: Remove redundant variable 's' from Parser/parser.c
https://hg.python.org/cpython/rev/a90f5e2b7160

--
nosy: +python-dev

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-03-27 Thread Berker Peksag 

Berker Peksag added the comment:

Thanks for the patch, Oren!

--
nosy: +berker.peksag
resolution:  -> fixed
stage: patch review -> resolved
status: open -> closed
versions:  -Python 3.5

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-01-15 Thread Oren Milman 

New submission from Oren Milman:

In Parser\parser.c in classify, the 'str' parameter is assigned into the local 
variable 's'. However, 'str' is not used anywhere else in the function, which 
makes 's' redundant.

My proposal is to simply remove 's', and just use 'str' instead.

The diff is attached.

I played a little with the interpreter, and everything worked as usual.
In addition, I run 'python -m test' (on my 64-bit Windows 10) before and after 
applying the patch, and got the same output:
354 tests OK.
1 test altered the execution environment:
test_subprocess
45 tests skipped:
test_bz2 test_crypt test_curses test_dbm_gnu test_dbm_ndbm
test_devpoll test_epoll test_fcntl test_fork1 test_gdb test_grp
test_idle test_ioctl test_kqueue test_lzma test_nis test_openpty
test_ossaudiodev test_pipes test_poll test_posix test_pty test_pwd
test_readline test_resource test_smtpnet test_socketserver
test_spwd test_sqlite test_ssl test_syslog test_tcl
test_threadsignals test_timeout test_tix test_tk test_ttk_guionly
test_ttk_textonly test_urllib2net test_urllibnet test_wait3
test_wait4 test_winsound test_xmlrpc_net test_zipfile64

--
components: Interpreter Core
files: patchDiff.txt
messages: 258326
nosy: Oren Milman
priority: normal
severity: normal
status: open
title: redundant local copy of a char pointer in classify in Parser\parser.c
type: enhancement
versions: Python 3.6
Added file: http://bugs.python.org/file41629/patchDiff.txt

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-01-15 Thread SilentGhost 

Changes by SilentGhost :


--
nosy: +benjamin.peterson, brett.cannon, georg.brandl, ncoghlan, yselivanov

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-01-15 Thread Georg Brandl 

Georg Brandl added the comment:

Looks good to me. s was probably left over after a rewrite of the function.

--

___
Python tracker 

___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com